pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: ma100@hotmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17172: NaN compare error in hash agg
Date: Thu, 02 Sep 2021 17:28:04 -0400
Message-ID: <2359861.1630618084@sss.pgh.pa.us> (raw)
In-Reply-To: <2077133.1630510836@sss.pgh.pa.us>
References: <17172-7505bea9e04e230f@postgresql.org>
	<2077133.1630510836@sss.pgh.pa.us>

I wrote:
> This has been broken for a very long time.  Do we dare back-patch
> the fix?  Given the lack of complaints, maybe fixing it in HEAD/v14
> is enough.  OTOH, it's not likely that many people have hash indexes
> containing minus NaNs, so maybe it's okay to back-patch.

After further thought I concluded that there's little reason
not to back-patch.  If someone has -NaN in a hash index,
they'd need to re-index if they ever want to find that entry
again ... but it was already true that many queries would not
find that entry.  Hence, pushed to all branches.

			regards, tom lane





view thread (3+ messages)

Message-ID: <2359861.1630618084@sss.pgh.pa.us>
Permalink:  ../2359861.1630618084@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2359861.1630618084@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, ma100@hotmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17172: NaN compare error in hash agg
  In-Reply-To: <2359861.1630618084@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox