pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Adrian Ho <ml+postgresql@03s.net>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17083: [PATCH] PostgreSQL fails to build with OpenLDAP 2.5.x
Date: Sat, 10 Jul 2021 13:25:33 -0400
Message-ID: <2407482.1625937933@sss.pgh.pa.us> (raw)
In-Reply-To: <2377740.1625928629@sss.pgh.pa.us>
References: <cc729116-2a2d-9edd-a32d-4066b92e4a75@03s.net>
	<1677203.1625582865@sss.pgh.pa.us>
	<e78eb1f9-57b1-dae9-39c8-5dd72268be89@03s.net>
	<1860066.1625677051@sss.pgh.pa.us>
	<68D22062-EC78-47C5-BC46-EF2F77193E19@yesql.se>
	<YOaxpoHOiO7Q41F2@paquier.xyz>
	<2040197.1625774127@sss.pgh.pa.us>
	<C184CEB8-F2D5-4CD7-BDA1-D9F6AD43DD14@yesql.se>
	<YOezfzxbrMNMwoRg@paquier.xyz>
	<2229967.1625848816@sss.pgh.pa.us>
	<YOmK4fQFpadlAt08@paquier.xyz>
	<2377740.1625928629@sss.pgh.pa.us>

I wrote:
> Oh, that's interesting.  elver's failure seems to be because it's now
> deciding it doesn't HAVE_LDAP_INITIALIZE.  However, on my RHEL8 machine
> the current configure coding is still finding ldap_initialize;

... or not.  I must have been seeing what I expected to see yesterday,
because when I check it again now, it isn't finding ldap_initialize.

Close inspection of the Autoconf manual reveals the problem:
AC_CHECK_LIB updates LIBS only as part of its *default* success
action, which the current coding isn't using for libldap_r.
So we arrive at the ldap_initialize test with neither library
in LIBS.

But we really ought to probe libldap not libldap_r for
ldap_initialize, because we use that only on the backend side.
So the right fix is to do that probe before we mess around
with libldap_r, which I've now done.

			regards, tom lane





view thread (15+ messages)

Message-ID: <2407482.1625937933@sss.pgh.pa.us>
Permalink:  ../2407482.1625937933@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2407482.1625937933@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, daniel@yesql.se, ml+postgresql@03s.net, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17083: [PATCH] PostgreSQL fails to build with OpenLDAP 2.5.x
  In-Reply-To: <2407482.1625937933@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox