From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Adrian Ho <ml+postgresql@03s.net>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17083: [PATCH] PostgreSQL fails to build with OpenLDAP 2.5.x
Date: Thu, 8 Jul 2021 17:04:54 +0900
Message-ID: <YOaxpoHOiO7Q41F2@paquier.xyz> (raw)
In-Reply-To: <68D22062-EC78-47C5-BC46-EF2F77193E19@yesql.se>
References: <17083-a19190d9591946a7@postgresql.org>
<1666182.1625579201@sss.pgh.pa.us>
<cc729116-2a2d-9edd-a32d-4066b92e4a75@03s.net>
<1677203.1625582865@sss.pgh.pa.us>
<e78eb1f9-57b1-dae9-39c8-5dd72268be89@03s.net>
<1860066.1625677051@sss.pgh.pa.us>
<68D22062-EC78-47C5-BC46-EF2F77193E19@yesql.se>
On Thu, Jul 08, 2021 at 09:53:11AM +0200, Daniel Gustafsson wrote:
> Couldn't we add a version check to find if we have < 2.5 or >= 2.5, and adjust
> libs accordingly? Alternatively we could perhaps check for
> LDAP_API_FEATURE_X_OPENLDAP_REENTRANT which IIUC when set defines -lldap to be
> reentrant.
Would you fetch the version number directly from the library? I'd
like to think that it could be more simple to rely on an object
defined in the library instead as that's what we do for OpenSSL. Now
OpenLDAP has not a history with forks as complicated as OpenSSL,
making a version number something more reliable?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, daniel@yesql.se, tgl@sss.pgh.pa.us, ml+postgresql@03s.net, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17083: [PATCH] PostgreSQL fails to build with OpenLDAP 2.5.x
In-Reply-To: <YOaxpoHOiO7Q41F2@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox