pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: oleg9301 xz <oleg9301@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org, Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: BUG #16799: postgresql log issue(last completed transaction was at log time)
Date: Thu, 31 Dec 2020 11:27:27 -0500
Message-ID: <2457719.1609432047@sss.pgh.pa.us> (raw)
In-Reply-To: <CAFyBvAiZh2EHHzfnfuNnuJRNTd4hmtmVpAJHOA7YiYtwP6XBcw@mail.gmail.com>
References: <16799-af1b66268fe20d0d@postgresql.org>
	<2452476.1609428095@sss.pgh.pa.us>
	<CAFyBvAiZh2EHHzfnfuNnuJRNTd4hmtmVpAJHOA7YiYtwP6XBcw@mail.gmail.com>

oleg9301 xz <oleg9301@gmail.com> writes:
> чт, 31 дек. 2020 г. в 18:21, Tom Lane <tgl@sss.pgh.pa.us>:
>> PG Bug reporting form <noreply@postgresql.org> writes:
>>> After recovering postgresql from barman, in version 12.5 I don't have
>>> next string
>>> "last completed transaction was at log time %s"
>>> In postgresql 11.9-1.pgdg100+1 everything fine.

>> I don't see any reason to believe there's a bug here.  That message
>> would only appear if at least one transaction commit or abort record was
>> replayed from WAL, and it's quite possible there wouldn't have been.

> There is always transations to commit, I(barman) do pg_basebackup once a
> day, and recieve wal with pg_receivewal(standby slot). And everything is
> fine, i have all data on OLAP DB(restore 6 times in day)
> (all WAL files playing correctly).

Hmm.  I poked a bit into the code, and I see what is different in v12:
commit 7acf8a876 ("Make crash recovery ignore recovery target settings")
caused all of recoveryStopsAfter() to be skipped when
!ArchiveRecoveryRequested ... including the part that updates
recoveryLastXTime.

Fujii-san, Peter, was that actually intended?  The commit message
doesn't mention it.  It's certainly arguable that this is cosmetic
and we don't care enough to contort the code to keep the old behavior
here.

			regards, tom lane





view thread (4+ messages)

Message-ID: <2457719.1609432047@sss.pgh.pa.us>
Permalink:  ../2457719.1609432047@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2457719.1609432047@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, oleg9301@gmail.com, masao.fujii@oss.nttdata.com, peter.eisentraut@enterprisedb.com
  Subject: Re: BUG #16799: postgresql log issue(last completed transaction was at log time)
  In-Reply-To: <2457719.1609432047@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox