pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: jungleboogie0@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'
Date: Mon, 19 Aug 2019 01:14:03 -0400
Message-ID: <25241.1566191643@sss.pgh.pa.us> (raw)
In-Reply-To: <20190819044625.GA18166@paquier.xyz>
References: <15964-c1753bdfed722e04@postgresql.org>
	<24757.1566073861@sss.pgh.pa.us>
	<20190817210025.v4bblh4lhsxajmlj@alap3.anarazel.de>
	<6402.1566079145@sss.pgh.pa.us>
	<20190817224142.gq57z3cwt7c76dtk@alap3.anarazel.de>
	<20190819044625.GA18166@paquier.xyz>

Michael Paquier <michael@paquier.xyz> writes:
> On Sat, Aug 17, 2019 at 03:41:42PM -0700, Andres Freund wrote:
>>> Indeed.  I've confirmed the bug report on a local OpenBSD 6.4 build
>>> (clang 6.0.0), and with "make -k" I can see that reindexdb.c fails
>>> likewise.  But this is unsurprising given that POSIX says that
>>> FD_SETSIZE is declared by sys/select.h.

>> Right.

> Okay, then the current code is broken in this sense.  It was
> surprising to not see the buildfarm complain about that though.

Yeah --- see 51c3e9fad.  We should have set up a modern-OpenBSD
buildfarm member back then, but failed to.  Let's do that this
time.

			regards, tom lane





view thread (47+ messages)  latest in thread

Message-ID: <25241.1566191643@sss.pgh.pa.us>
Permalink:  ../25241.1566191643@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/25241.1566191643@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, andres@anarazel.de, jungleboogie0@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'
  In-Reply-To: <25241.1566191643@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox