pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Klaudie Willis <Klaudie.Willis@protonmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: When Update balloons memory
Date: Tue, 11 Jan 2022 14:54:28 -0500
Message-ID: <2761801.1641930868@sss.pgh.pa.us> (raw)
In-Reply-To: <CAH2-Wzk=5jGMdS4UWmQJ9m3YQGot9K5ZcBqCQ-_J55rjK7MHAA@mail.gmail.com>
References: <wJYzIcLjhFnsbCK8sy4lZZAojx7m04FwjsGF4WbrKj0gj2wLpaycQSEN1mtBUlhSAQGRvEdxZTwWRNV39UevSNWg8-h-tvWAL61pV4IuhW4=@protonmail.com>
	<3484560.1638889073@sss.pgh.pa.us>
	<YAjwxLJ1p4do7V4OkzpgwXrfV-fywioBsfvFaHnuY1Hbe-NjM0tsaCpJ_-KXwvFKF2YsQzQLCnFFFlMnyzd6TJ9UcXnQpcZfdZ1ZDcCqXIE=@protonmail.com>
	<189763.1639437451@sss.pgh.pa.us>
	<lviv_r7tA44gnx3rRU8VYdseWJLx-AzQCbsgdyz2-1Lse9ZmqDeLnzfDkBTut26kxlPZ8FX36TiKmCtXi5gAfhI-JVu-2n8fu7Dcta0Y3Ek=@protonmail.com>
	<261065.1639497535@sss.pgh.pa.us>
	<CAH2-Wzm54LA8EeOf6-cFZCHwigZ0YgQVgcmuyFr=b8w2pzQgzA@mail.gmail.com>
	<377324.1639510427@sss.pgh.pa.us>
	<CAH2-Wzk=5jGMdS4UWmQJ9m3YQGot9K5ZcBqCQ-_J55rjK7MHAA@mail.gmail.com>

Peter Geoghegan <pg@bowt.ie> writes:
> I haven't made the code use pull_varnos(), which you suggested back in
> December. It looks like it would be tricky to do that from the
> executor, since pull_varnos() has a PlannerInfo* argument. That has
> been the case since your commit 55dc86eca7 from January 2021, "Fix
> pull_varnos' miscomputation of relids set for a PlaceHolderVar".
> Please advise.

Pass NULL for that, per 6867f963e:

https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=6867f963e#patch2

We'd have to back-patch that bit, but I don't see any problem
with doing so.

			regards, tom lane





view thread (22+ messages)  latest in thread

Message-ID: <2761801.1641930868@sss.pgh.pa.us>
Permalink:  ../2761801.1641930868@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2761801.1641930868@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pg@bowt.ie, Klaudie.Willis@protonmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: When Update balloons memory
  In-Reply-To: <2761801.1641930868@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox