From: Tom Lane <tgl@sss.pgh.pa.us>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: mb.alzouabi@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18245: pg_restore accepts same output file name as input file name
Date: Thu, 14 Dec 2023 09:50:01 -0500
Message-ID: <2781744.1702565401@sss.pgh.pa.us> (raw)
In-Reply-To: <ZXsTb3HttMOyyBox@jrouhaud>
References: <18245-eed25801b2d599c9@postgresql.org>
<E7AEB7F8-BB3E-403F-ACDB-E06AF4E37861@yesql.se>
<ZXsTb3HttMOyyBox@jrouhaud>
Julien Rouhaud <rjuju123@gmail.com> writes:
> On Wed, Dec 13, 2023 at 09:44:26AM +0100, Daniel Gustafsson wrote:
>> Something like the attached (untested) sketch should be enough I think.
> I'm wondering if it would be worth adding some canonicalize_path() calls while
> at it, ISTM that such mistakes are likely to happen when invoking pg_restore
> manually, so having slightly different wording for the exact same file wouldn't
> surprising.
I'm a little dubious about the value of this; but if we're going to do
it, comparing post-canonicalize_path strings does seem like the right
way.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, rjuju123@gmail.com, daniel@yesql.se, mb.alzouabi@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18245: pg_restore accepts same output file name as input file name
In-Reply-To: <2781744.1702565401@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox