pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: jungleboogie0@gmail.com, pgsql-bugs@lists.postgresql.org, Michael Paquier <michael@paquier.xyz>
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'
Date: Sat, 17 Aug 2019 20:59:56 -0400
Message-ID: <28480.1566089996@sss.pgh.pa.us> (raw)
In-Reply-To: <20190818001858.ho3ev4z57fqhs7a5@alap3.anarazel.de>
References: <15964-c1753bdfed722e04@postgresql.org>
	<24757.1566073861@sss.pgh.pa.us>
	<20190817210025.v4bblh4lhsxajmlj@alap3.anarazel.de>
	<6402.1566079145@sss.pgh.pa.us>
	<20190817224142.gq57z3cwt7c76dtk@alap3.anarazel.de>
	<20190818001858.ho3ev4z57fqhs7a5@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> Hm. This made me think: Why is
>                 if (concurrentCons > FD_SETSIZE - 1)
> a useful test / error message?

Good point, it's not.  Subtracting off 10 or so might be reasonable.

> What is the reason that this doesn't use poll() in the first place?

We still support platforms without that, no?  Windows, for one.

			regards, tom lane





view thread (47+ messages)  latest in thread

Message-ID: <28480.1566089996@sss.pgh.pa.us>
Permalink:  ../28480.1566089996@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/28480.1566089996@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, alvherre@2ndquadrant.com, dilipbalaut@gmail.com, michael@paquier.xyz
  Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'
  In-Reply-To: <28480.1566089996@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox