pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: paul.vanderlinden@mapcreator.eu, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Subject: Re: BUG #15460: Error while creating index or constraint
Date: Mon, 29 Oct 2018 12:28:25 -0400
Message-ID: <29352.1540830505@sss.pgh.pa.us> (raw)
In-Reply-To: <CAH2-WzmS+eYnDuULw5M=cFsxJ6xxKkaysdLbh2mO26Wb_7wZBg@mail.gmail.com>
References: <15460-b6db80de822fa0ad@postgresql.org>
	<CAH2-Wzk=pj9SN+=HZCYwAc3WHe+_SErqA3xoLxj2y_GwSQ+Dag@mail.gmail.com>
	<26974.1540826748@sss.pgh.pa.us>
	<CAH2-WzmS+eYnDuULw5M=cFsxJ6xxKkaysdLbh2mO26Wb_7wZBg@mail.gmail.com>

Peter Geoghegan <pg@bowt.ie> writes:
> On Mon, Oct 29, 2018 at 3:25 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Sounds like papering over the bug ...

> I may have been unclear. It would be papering over the bug if I went
> ahead and did that now.

> The advantage of getting the file size from shared memory is that it
> doesn't leave it up to code like BufFileOpenShared() to find
> everything through readdir() iteration, an approach that might not be
> totally portable. We'll reliably fail if all BufFile segments cannot
> be accounted for with the size-in-shared-memory approach, which seems
> more robust. I wouldn't be surprised if that actually was the correct
> fix in the end.

Perhaps.  Anyway, I think we agree that we should identify why it's
failing before we decide on a fix.

			regards, tom lane




view thread (42+ messages)  latest in thread

Message-ID: <29352.1540830505@sss.pgh.pa.us>
Permalink:  ../29352.1540830505@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/29352.1540830505@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pg@bowt.ie, pgsql-bugs@lists.postgresql.org, hlinnaka@iki.fi
  Subject: Re: BUG #15460: Error while creating index or constraint
  In-Reply-To: <29352.1540830505@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox