From: Tom Lane <tgl@sss.pgh.pa.us>
To: Hamid Akhtar <hamid.akhtar@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16346: pg_upgrade fails on a trigger with a comment
Date: Wed, 08 Apr 2020 11:34:17 -0400
Message-ID: <29776.1586360057@sss.pgh.pa.us> (raw)
In-Reply-To: <CANugjhsTWXx8bEsZU5+RVYHNd5bezeX-cv4LSauBRYx27Ckbuw@mail.gmail.com>
References: <16346-6210ad7a0ea81be1@postgresql.org>
<CANugjhsWLbJsgTCQkm1du3BRZXsCBPFSrmPn0oyDKVWWr6HS_w@mail.gmail.com>
<CANugjhsTWXx8bEsZU5+RVYHNd5bezeX-cv4LSauBRYx27Ckbuw@mail.gmail.com>
Hamid Akhtar <hamid.akhtar@gmail.com> writes:
> To recap, the attached patch moves restoration of comments to the
> RESTORE_PASS_POST_ACL. This ensures that comments are
> restored in a PASS when essentially all required objects are created
> including event triggers and materialized views (and any other db
> objects).
This is surely not a good idea as it stands, because it delays restore
of *all* object comments to the very end. That's not nice for parallel
restores, and it also has large impact on pg_dump's behavior in cases
that have nothing to do with event triggers; which could cause unforeseen
problems.
The right way is to postpone only event trigger comments. I fixed it
that way and pushed it.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, hamid.akhtar@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16346: pg_upgrade fails on a trigger with a comment
In-Reply-To: <29776.1586360057@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox