From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: jungleboogie0@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'
Date: Fri, 23 Aug 2019 10:58:14 -0400
Message-ID: <29797.1566572294@sss.pgh.pa.us> (raw)
In-Reply-To: <20190823015921.GD2328@paquier.xyz>
References: <30820.1566397711@sss.pgh.pa.us>
<20190821143449.GA27852@alvherre.pgsql>
<20190822014739.GB1683@paquier.xyz>
<20190822150945.3xgbvk7qqyqkyjse@alap3.anarazel.de>
<20190823015921.GD2328@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> The latest patch does that:
> + pg_log_fatal("too many jobs for this platform's select() -- try %d"
> Do you have a better suggestion to offer, like a s#jobs#-j/--jobs#?
That seems over-punctuated, plus it burdens the reader with unnecessary
detail. Most SQL folk would be confused by the reference to SELECT,
I bet. (In fact, don't we have a style guideline against mentioning
particular syscalls?)
How about just "too many jobs for this platform -- try %d" ?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, andres@anarazel.de, alvherre@2ndquadrant.com, dilipbalaut@gmail.com, jungleboogie0@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'
In-Reply-To: <29797.1566572294@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox