pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Alexandra Wang <alexandra.wang.oss@gmail.com>
Cc: Chris Travers <chris.travers@stormatics.tech>
Cc: Farooq Rashed <farooq.rashed@desc.gov.ae>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: pg_rewind fails on Windows where tablespaces are used
Date: Tue, 14 Jan 2025 16:12:37 -0500
Message-ID: <2cfbe91b-06d1-4609-845c-135d8b5157f8@dunslane.net> (raw)
In-Reply-To: <CA+hUKGJDiwEtH3HnK8ZX=m1587jmHRCnnN_LP-cHCxUL6Gy59g@mail.gmail.com>
References: <CA+pA0kLc5VxOaO4WfLjmh7W0V+quVvVtT5CaRVRAZMuh0zft4Q@mail.gmail.com>
	<Zl6dsK5IcNGTL0qD@paquier.xyz>
	<5169f6d5-240e-49ec-9265-ddafa6e863bd@dunslane.net>
	<Zo3D3Y24Kd1eTV8n@paquier.xyz>
	<CAK98qZ0PLMWRKe=_oHjxwKKDQHZ0wb5ntjiefWpe9V1r8J0b6w@mail.gmail.com>
	<ZxmAxLkKrDxc_0zx@paquier.xyz>
	<982f5caf-6536-4e9f-aeec-227f31114526@dunslane.net>
	<ZyAbpVS3t1tjN7a0@paquier.xyz>
	<CAD5tBc+q66kwQ=g1sbS6hesPEkjbUyFNghEG+V=vBrjsTOuDmQ@mail.gmail.com>
	<Zy1UTJpSnDdWsOsW@paquier.xyz>
	<CA+hUKGLbnv+pe3q1fYOVkLD3pMra7GuihfMxUN-1831YH9RYQg@mail.gmail.com>
	<5d8284d1-b7b2-4dfb-a686-429d9ae0b04e@dunslane.net>
	<039f5e85-6059-4c94-bf0b-20c38b9e24e3@dunslane.net>
	<CA+hUKGJDiwEtH3HnK8ZX=m1587jmHRCnnN_LP-cHCxUL6Gy59g@mail.gmail.com>


On 2025-01-08 We 10:38 PM, Thomas Munro wrote:
> On Thu, Jan 9, 2025 at 3:45 AM Andrew Dunstan <andrew@dunslane.net> wrote:
>> Those patches didn't actually include any tests. I guess the best test
>> would be to create a chain of several junction points and then run
>> initdb on the leaf of the chain?
> Yeah I think the three interesting cases were initdb when run under
> junctions like these:
>
> 1.  Volume GUID format: mklink /J foo \\?\Volume{12341234-1234...},
> expected to break without patch
> 2.  Chain: mklink /J C:\\aaa1 C:\\aaa2, mkdir /J C:\\aaa2 c:\\aaa3,
> expected to break without patch
> 3.  Chain of length > 8, expected to fail with ELOOP once the patch is applied.
>
> (Syntax may be off, I just googled it but don't have Windows to try).
>
> The way to get decent tests for this stuff and all the rest of the
> wrappers would probably be to develop this test suite further:
>
> https://www.postgresql.org/message-id/flat/CA%2BhUKG%2BajSQ_8eu2AogTncOnZ5me2D-Cn66iN_-wZnRjLN%2Bicg...



I can confirm that these two patches apply cleanly to releases 13 .. 15, 
that builds are also clean, and that tests 1..3 above pass/fail as 
expected. Tested on a WS2019 instance.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com






view thread (18+ messages)  latest in thread

Message-ID: <2cfbe91b-06d1-4609-845c-135d8b5157f8@dunslane.net>
Permalink:  ../2cfbe91b-06d1-4609-845c-135d8b5157f8@dunslane.net/
Also on:    postgresql.org/message-id/2cfbe91b-06d1-4609-845c-135d8b5157f8@dunslane.net

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: andrew@dunslane.net, thomas.munro@gmail.com, michael@paquier.xyz, alexandra.wang.oss@gmail.com, chris.travers@stormatics.tech, farooq.rashed@desc.gov.ae, pgsql-bugs@lists.postgresql.org
  Subject: Re: pg_rewind fails on Windows where tablespaces are used
  In-Reply-To: <2cfbe91b-06d1-4609-845c-135d8b5157f8@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox