pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Viktor Holmberg <v@viktorh.net>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: ISN extension - wrong volatility level for isn_weak() function
Date: Fri, 14 Mar 2025 11:13:49 -0400
Message-ID: <3074065.1741965229@sss.pgh.pa.us> (raw)
In-Reply-To: <de89bd5c-9f51-4891-8a38-d03ed06ebd1d@Spark>
References: <ae6ed432-4491-4030-be20-3ea69d03a098@Spark>
	<790bc1f9-74dc-4b50-94d2-8147315b1556@Spark>
	<51C655A4-46FB-4A40-BAE5-26A76B31D3EE@yesql.se>
	<3052531.1741961784@sss.pgh.pa.us>
	<de89bd5c-9f51-4891-8a38-d03ed06ebd1d@Spark>

Viktor Holmberg <v@viktorh.net> writes:
> I haven’t checked the source code, but yes the isn_weak feature has some footgun potential. As it doesn’t respect transactions, but rather sets a flag on session level, it’s easy for the “isn weakness” to leak out into a connection pool.

Yeah, really that ought to be a GUC I should think.  There isn't
anything well-designed about it ...

I found some prior discussion here:

https://www.postgresql.org/message-id/flat/C12AE0A2A752416C79F3EE81%40teje

but we don't seem to have pulled the trigger on changing anything.

			regards, tom lane





view thread (15+ messages)  latest in thread

Message-ID: <3074065.1741965229@sss.pgh.pa.us>
Permalink:  ../3074065.1741965229@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3074065.1741965229@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, v@viktorh.net, daniel@yesql.se, pgsql-bugs@lists.postgresql.org
  Subject: Re: ISN extension - wrong volatility level for isn_weak() function
  In-Reply-To: <3074065.1741965229@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox