pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Emil Iggland <emil@iggland.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: BUG #15858: could not stat file - over 4GB
Date: Mon, 12 Oct 2020 11:13:38 -0400
Message-ID: <3100396.1602515618@sss.pgh.pa.us> (raw)
In-Reply-To: <CAC+AXB25aAHGzmrvKd97jQK3wjYHzbhb72wpvGym6OmFqpj5Sw@mail.gmail.com>
References: <CAC+AXB2164H1JjSOPwf=PK5AhRVHSApzC5NAU-443HSu7RotSA@mail.gmail.com>
	<160209800917.1171.12856112208955258625.pgcf@coridan.postgresql.org>
	<2831747.1602274940@sss.pgh.pa.us>
	<CAC+AXB0g44SbvSpC86o_1HWh8TAU2pZrMRW6tJT-dkijotx5Qg@mail.gmail.com>
	<20201010122353.GA2985@paquier.xyz>
	<CAC+AXB0f-pGWb2Rx1amCRCpjKohKLQ4L+Vsy7JaeHVgwJgbnGA@mail.gmail.com>
	<2920041.1602351778@sss.pgh.pa.us>
	<CAC+AXB36ZK=yzRVR4PkKVU0PQEP2SpaFC-_eavOm99U=f0kAhw@mail.gmail.com>
	<20201011002452.GA6607@paquier.xyz>
	<2944395.1602376488@sss.pgh.pa.us>
	<20201012010108.GB2346@paquier.xyz>
	<3062457.1602473238@sss.pgh.pa.us>
	<CAC+AXB25aAHGzmrvKd97jQK3wjYHzbhb72wpvGym6OmFqpj5Sw@mail.gmail.com>

=?UTF-8?Q?Juan_Jos=C3=A9_Santamar=C3=ADa_Flecha?= <juanjo.santamaria@gmail.com> writes:
> On Mon, Oct 12, 2020 at 5:27 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Michael Paquier <michael@paquier.xyz> writes:
>>> Why are we forcing errno=ENOENT here?  Wouldn't it be correct to use
>>> _dosmaperr(GetLastError()) to get the correct errno?

>> Fair question.  Juan, was there some good reason not to look at
>> GetLastError() in this step?

> Uhm, a good question indeed, forcing errno serves no purpose there.

OK, changed.

			regards, tom lane





view thread (45+ messages)  latest in thread

Message-ID: <3100396.1602515618@sss.pgh.pa.us>
Permalink:  ../3100396.1602515618@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3100396.1602515618@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, juanjo.santamaria@gmail.com, michael@paquier.xyz, emil@iggland.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: BUG #15858: could not stat file - over 4GB
  In-Reply-To: <3100396.1602515618@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox