pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: Oleksandr Shulgin <oleksandr.shulgin@zalando.de>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: exclusion@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16486: Prompted password is ignored when password specified in connection string
Date: Wed, 02 Sep 2020 10:46:19 -0400
Message-ID: <317208.1599057979@sss.pgh.pa.us> (raw)
In-Reply-To: <20200902131858.GD13613@momjian.us>
References: <16486-b9c93d71c02c4907@postgresql.org>
	<2090524.1591652199@sss.pgh.pa.us>
	<CAKFQuwbk=SDVVhe=P=eAsX4Zip_0tR+vZOOMM-VvHAH0=We=_g@mail.gmail.com>
	<2110959.1591655226@sss.pgh.pa.us>
	<2142411.1591667958@sss.pgh.pa.us>
	<20200901203846.GA13613@momjian.us>
	<CACACo5RDv3ahJ_whCmMRRqc6Y6C5XVStJ-kC5JJgiZ5KM7TRFA@mail.gmail.com>
	<20200902131858.GD13613@momjian.us>

Bruce Momjian <bruce@momjian.us> writes:
> On Wed, Sep  2, 2020 at 09:54:37AM +0200, Oleksandr Shulgin wrote:
>> AFAIK, there is nothing in the protocol that forces psql to make an extra
>> connection attempt.  If libpq provided a means to pass a password-prompt
>> callback, no extra connection would be needed I think?

> That is true.  I don't think we want the backend to be kept open waiting
> for someone to type a password, which is why, I think, we don't do it
> that way.

Yeah, I think this is an ancient value judgement.  Sure, it's pretty
questionable whether spawning a backend a second time is better than
tying one up waiting for a human to type a password.  (It's going to
be spending a lot of time waiting for that human later on, anyway.)
The real point IMO is that libpq's connection API is already
unreasonably complicated, and providing a callback of this sort
would make it even messier.  A different client library might make
a different choice, perhaps.

			regards, tom lane





view thread (17+ messages)  latest in thread

Message-ID: <317208.1599057979@sss.pgh.pa.us>
Permalink:  ../317208.1599057979@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/317208.1599057979@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, bruce@momjian.us, oleksandr.shulgin@zalando.de, david.g.johnston@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16486: Prompted password is ignored when password specified in connection string
  In-Reply-To: <317208.1599057979@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox