pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Sam James <sam@gentoo.org>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: Build failure with GCC 15 (defaults to -std=gnu23)
Date: Sun, 17 Nov 2024 20:59:23 -0500
Message-ID: <3198438.1731895163@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+hUKGJBNYAAYE51Ef-reKo1cUDvs3GgnChyh4ETqiSVQ0MR5w@mail.gmail.com>
References: <87o72eo9iu.fsf@gentoo.org>
	<3073930.1731867112@sss.pgh.pa.us>
	<CA+hUKGJsuBiBcYnmJhGUNEg6Ud3n+C3K8c6em6RTOgu1E-dbwg@mail.gmail.com>
	<3160019.1731875201@sss.pgh.pa.us>
	<CA+hUKGLJnhpJBrsutH2aK91ARMS+XCez5P8XrR-kwdfSyLXGiQ@mail.gmail.com>
	<3169079.1731880169@sss.pgh.pa.us>
	<CA+hUKGJEnmapE7YYEfdJYZ-yGmcDpVGRrQ_eEVdcux26ZNJq_g@mail.gmail.com>
	<3175762.1731883847@sss.pgh.pa.us>
	<CA+hUKGJBNYAAYE51Ef-reKo1cUDvs3GgnChyh4ETqiSVQ0MR5w@mail.gmail.com>

Thomas Munro <thomas.munro@gmail.com> writes:
> I found a few lines we could just delete in master.  I wonder if we
> should also just require sizeof(bool) == 1 more explicitly going
> forward with an error, since we don't have coverage or any expectation
> of ever getting any for the alternative code AFAICS, even if it is
> small.

Yeah, that's a fair criticism.  I don't think we've tested that code
path since I retired prairiedog, so who's to say that it works even
now?  Maybe it's best to just delete that code, and if we ever find a
new platform with wider bool, figure out what to do at that time.

			regards, tom lane





view thread (42+ messages)  latest in thread

Message-ID: <3198438.1731895163@sss.pgh.pa.us>
Permalink:  ../3198438.1731895163@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3198438.1731895163@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, sam@gentoo.org, pgsql-bugs@lists.postgresql.org
  Subject: Re: Build failure with GCC 15 (defaults to -std=gnu23)
  In-Reply-To: <3198438.1731895163@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox