pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Takeshi Ideriha <iderihatakeshi@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Zhijie Hou <houzhijie22@gmail.com>
Cc: shihao zhong <zhong950419@gmail.com>
Cc: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Cc: alpkeles99@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19760: CLUSTER loses a row the transaction inserted and then updated in a rolled-back subtransaction
Date: Thu, 22 Oct 2026 13:55:50 +0900
Message-ID: <31ce67ec-f31a-4e8d-89e5-833fbb4c648a@gmail.com> (raw)
In-Reply-To: <atl_RW26JlkZcTGb@paquier.xyz>
References: <5fff280b-96c4-497f-bbfc-0af95b9844b3@gmail.com>
	<CAGRkXqSo9vZ=7mw_X0tjH1-Wwdz8nWu9xpdX1x8hVM8tCazKAA@mail.gmail.com>
	<949ad7b3-2b0e-40dc-b6ac-e84da432149b@gmail.com>
	<atcbPTfcO9rihmbD@paquier.xyz>
	<atceNofaGIE2dOFn@paquier.xyz>
	<CAGRkXqStu17-_568HNTqz_Qh7=FKTaRO2A572hizQuhMBbExvQ@mail.gmail.com>
	<athl6okS1xEgasD3@paquier.xyz>
	<CAFvd2n_qVC1yqVEZXrh3W1gandgWUcYsOgsiY7xzU_Vy=qxWdQ@mail.gmail.com>
	<atlzUChbZatun_HQ@paquier.xyz>
	<a30056b5-be05-41f7-93fe-6b2c7d6b2dd6@gmail.com>
	<atl_RW26JlkZcTGb@paquier.xyz>


On 2026/10/22 12:13, Michael Paquier wrote:
> Yeah, I don't think that we should begin using SetHintBits() outside> of
heapam_visibility.c when it comes down to heap as a table AM.

Sure, thank you for the reply.

>> However, it would still be another API violation, wouldn't it? We also
>> needs to figure out the multixact race issue. I'm trying to look into
>> multixact part as much as possible.
> 
> What do you think about the first SetHintBits() added for the
> subtransaction aborted case?  This one seems acceptable here, by
> itself..
+1 for this. Setting the hint bit for the aborted subtransaction inside
HeapTupleSatisfiesVacuumHorizon is safe and not harmful for the
performance.

Regards,
Takeshi Ideriha






view thread (30+ messages)  latest in thread

Message-ID: <31ce67ec-f31a-4e8d-89e5-833fbb4c648a@gmail.com>
Permalink:  ../31ce67ec-f31a-4e8d-89e5-833fbb4c648a@gmail.com/
Also on:    postgresql.org/message-id/31ce67ec-f31a-4e8d-89e5-833fbb4c648a@gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: iderihatakeshi@gmail.com, michael@paquier.xyz, houzhijie22@gmail.com, zhong950419@gmail.com, ayushtiwari.slg01@gmail.com, alpkeles99@gmail.com
  Subject: Re: BUG #19760: CLUSTER loses a row the transaction inserted and then updated in a rolled-back subtransaction
  In-Reply-To: <31ce67ec-f31a-4e8d-89e5-833fbb4c648a@gmail.com>
  References: <5fff280b-96c4-497f-bbfc-0af95b9844b3@gmail.com> <CAGRkXqSo9vZ=7mw_X0tjH1-Wwdz8nWu9xpdX1x8hVM8tCazKAA@mail.gmail.com> <949ad7b3-2b0e-40dc-b6ac-e84da432149b@gmail.com> <atcbPTfcO9rihmbD@paquier.xyz> <atceNofaGIE2dOFn@paquier.xyz> <CAGRkXqStu17-_568HNTqz_Qh7=FKTaRO2A572hizQuhMBbExvQ@mail.gmail.com> <athl6okS1xEgasD3@paquier.xyz> <CAFvd2n_qVC1yqVEZXrh3W1gandgWUcYsOgsiY7xzU_Vy=qxWdQ@mail.gmail.com> <atlzUChbZatun_HQ@paquier.xyz> <a30056b5-be05-41f7-93fe-6b2c7d6b2dd6@gmail.com> <atl_RW26JlkZcTGb@paquier.xyz> <31ce67ec-f31a-4e8d-89e5-833fbb4c648a@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox