pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Takeshi Ideriha <iderihatakeshi@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
To: Zhijie Hou <houzhijie22@gmail.com>
Cc: shihao zhong <zhong950419@gmail.com>
Cc: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Cc: alpkeles99@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19760: CLUSTER loses a row the transaction inserted and then updated in a rolled-back subtransaction
Date: Thu, 22 Oct 2026 11:53:29 +0900
Message-ID: <a30056b5-be05-41f7-93fe-6b2c7d6b2dd6@gmail.com> (raw)
In-Reply-To: <atlzUChbZatun_HQ@paquier.xyz>
References: <CAJTYsWXQgkqEpecZK9MCFVV+504oOdueuenRf+xTfNf9BcKE-g@mail.gmail.com>
	<CAGRkXqRMvz-ZzC88_eXsyJZRpPXhE4_Fo6ueYdm5tpH+CHc6EQ@mail.gmail.com>
	<5fff280b-96c4-497f-bbfc-0af95b9844b3@gmail.com>
	<CAGRkXqSo9vZ=7mw_X0tjH1-Wwdz8nWu9xpdX1x8hVM8tCazKAA@mail.gmail.com>
	<949ad7b3-2b0e-40dc-b6ac-e84da432149b@gmail.com>
	<atcbPTfcO9rihmbD@paquier.xyz>
	<atceNofaGIE2dOFn@paquier.xyz>
	<CAGRkXqStu17-_568HNTqz_Qh7=FKTaRO2A572hizQuhMBbExvQ@mail.gmail.com>
	<athl6okS1xEgasD3@paquier.xyz>
	<CAFvd2n_qVC1yqVEZXrh3W1gandgWUcYsOgsiY7xzU_Vy=qxWdQ@mail.gmail.com>
	<atlzUChbZatun_HQ@paquier.xyz>

Hi

> 
> What I am really wondering is why do we actually need to fix *two*
> problems at once?  The first SetHintBits() looks like a no-brainer to
> me, and links to the second permutation in the test "s1_plain
> s1_count" where we do a CLUSTER after an UPDATE rollbacked to a
> previous savepoint.  I don't think that there is a need for an
> isolation test on this one, either, wouldn't a plain SQL sequence be
> sufficient?
>

> So the first step to me would be a "Divide and Conquer" strategy,
> where we should look at each problem independently instead of trying
> to do too much at once.
Thank you for sorting the issue out and setting the direction. I was
thinking of leaving first SetHintBits() in
HeapTupleSatisfiesVacuumHorizon() and moving the second SetHintBits() to
heapam_relation_copy_for_cluster() to solve the performance issue.
However, it would still be another API violation, wouldn't it? We also
needs to figure out the multixact race issue. I'm trying to look into
multixact part as much as possible.

Regards,
Takeshi Ideriha






view thread (30+ messages)  latest in thread

Message-ID: <a30056b5-be05-41f7-93fe-6b2c7d6b2dd6@gmail.com>
Permalink:  ../a30056b5-be05-41f7-93fe-6b2c7d6b2dd6@gmail.com/
Also on:    postgresql.org/message-id/a30056b5-be05-41f7-93fe-6b2c7d6b2dd6@gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: iderihatakeshi@gmail.com, michael@paquier.xyz, houzhijie22@gmail.com, zhong950419@gmail.com, ayushtiwari.slg01@gmail.com, alpkeles99@gmail.com
  Subject: Re: BUG #19760: CLUSTER loses a row the transaction inserted and then updated in a rolled-back subtransaction
  In-Reply-To: <a30056b5-be05-41f7-93fe-6b2c7d6b2dd6@gmail.com>
  References: <CAJTYsWXQgkqEpecZK9MCFVV+504oOdueuenRf+xTfNf9BcKE-g@mail.gmail.com> <CAGRkXqRMvz-ZzC88_eXsyJZRpPXhE4_Fo6ueYdm5tpH+CHc6EQ@mail.gmail.com> <5fff280b-96c4-497f-bbfc-0af95b9844b3@gmail.com> <CAGRkXqSo9vZ=7mw_X0tjH1-Wwdz8nWu9xpdX1x8hVM8tCazKAA@mail.gmail.com> <949ad7b3-2b0e-40dc-b6ac-e84da432149b@gmail.com> <atcbPTfcO9rihmbD@paquier.xyz> <atceNofaGIE2dOFn@paquier.xyz> <CAGRkXqStu17-_568HNTqz_Qh7=FKTaRO2A572hizQuhMBbExvQ@mail.gmail.com> <athl6okS1xEgasD3@paquier.xyz> <CAFvd2n_qVC1yqVEZXrh3W1gandgWUcYsOgsiY7xzU_Vy=qxWdQ@mail.gmail.com> <atlzUChbZatun_HQ@paquier.xyz> <a30056b5-be05-41f7-93fe-6b2c7d6b2dd6@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox