From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: wliang@stu.xidian.edu.cn, pgsql-bugs <pgsql-bugs@lists.postgresql.org>
Subject: Re: Report a potential memory leak in setup_config()
Date: Tue, 15 Feb 2022 21:38:11 -0500
Message-ID: <3244453.1644979091@sss.pgh.pa.us> (raw)
In-Reply-To: <3243399.1644978358@sss.pgh.pa.us>
References: <64ee7543.20d.17efb1270ca.Coremail.wliang@stu.xidian.edu.cn>
<A7070803-5A15-486E-AE04-ECC13CD10038@yesql.se>
<3052163.1644942806@sss.pgh.pa.us>
<20220216012953.6d7bzmsblqou3ru4@alap3.anarazel.de>
<3239746.1644975946@sss.pgh.pa.us>
<20220216022118.vvijtgd5rl2b6ucv@alap3.anarazel.de>
<3243399.1644978358@sss.pgh.pa.us>
I wrote:
> Yeah, I read that. I think making the backend read these files directly
> makes a ton of sense, so I'm no longer very excited about improving the
> performance or memory consumption of the replace_token stuff.
Actually, wait a second. I grant your point about postgres.bki, but
a whole lot of the replace_token calls in initdb are messing with
the configuration files, which (a) is something I don't see changing,
and (b) pretty much none of that could be pushed back to build time.
So even though the config files are a lot smaller than postgres.bki,
maybe there's still a point in polishing replace_token a bit.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, daniel@yesql.se, pgsql-bugs@lists.postgresql.org
Subject: Re: Report a potential memory leak in setup_config()
In-Reply-To: <3244453.1644979091@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox