From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ian R. Campbell <ian.campbell@thepathcentral.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: Missing include in float.h
Date: Sun, 30 Jan 2022 13:38:40 -0500
Message-ID: <324553.1643567920@sss.pgh.pa.us> (raw)
In-Reply-To: <CAOC8YUd7H-REg7sqQD-kcUaE2iCMitimcSGhr5nLYRKq3k1zZQ@mail.gmail.com>
References: <CAOC8YUd7H-REg7sqQD-kcUaE2iCMitimcSGhr5nLYRKq3k1zZQ@mail.gmail.com>
"Ian R. Campbell" <ian.campbell@thepathcentral.com> writes:
> In PG 14, the source file "float.h" has one include:
> <math.h>
> It is missing "c.h", which contains the definitions for PGDLLIMPORT,
> float4, float8, etc.
This is standard practice in our header files: they assume that
the calling .c file has already included c.h, postgres.h, or
postgres_fe.h, as appropriate.
There are some portability hacks in c.h that don't work if any
other header is included first, so there would be little
value in trying to include it via other methods.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, ian.campbell@thepathcentral.com, pgsql-bugs@lists.postgresql.org
Subject: Re: Missing include in float.h
In-Reply-To: <324553.1643567920@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox