pg.ddx.io pgsql-bugs@postgresql.org mailing list archivehelp / color / mirror / Atom feed
Missing include in float.h 2+ messages / 2 participants [nested] [flat]
* Missing include in float.h @ 2022-01-30 16:32 Ian R. Campbell <ian.campbell@thepathcentral.com> 2022-01-30 18:38 ` Re: Missing include in float.h Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 1 reply; 2+ messages in thread From: Ian R. Campbell @ 2022-01-30 16:32 UTC (permalink / raw) To: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org> In PG 14, the source file "float.h" has one include: <math.h> It is missing "c.h", which contains the definitions for PGDLLIMPORT, float4, float8, etc. I have the latest Windows installation from EDB. I checked in doxygen and the include is missing there, too: https://doxygen.postgresql.org/float_8h_source.html Best, Ian Campbell ^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: Missing include in float.h 2022-01-30 16:32 Missing include in float.h Ian R. Campbell <ian.campbell@thepathcentral.com> @ 2022-01-30 18:38 ` Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2022-01-30 18:38 UTC (permalink / raw) To: Ian R. Campbell <ian.campbell@thepathcentral.com>; +Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org> "Ian R. Campbell" <ian.campbell@thepathcentral.com> writes: > In PG 14, the source file "float.h" has one include: > <math.h> > It is missing "c.h", which contains the definitions for PGDLLIMPORT, > float4, float8, etc. This is standard practice in our header files: they assume that the calling .c file has already included c.h, postgres.h, or postgres_fe.h, as appropriate. There are some portability hacks in c.h that don't work if any other header is included first, so there would be little value in trying to include it via other methods. regards, tom lane ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-01-30 18:38 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-01-30 16:32 Missing include in float.h Ian R. Campbell <ian.campbell@thepathcentral.com> 2022-01-30 18:38 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox