From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Ferdi Smit <FerdiSmit@optiver.com>
Cc: Floris Van Nee <florisvannee@optiver.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: incorrect pg_dump output due to not handling dropped roles correctly
Date: Wed, 29 Jan 2020 14:46:45 -0500
Message-ID: <32560.1580327205@sss.pgh.pa.us> (raw)
In-Reply-To: <CAOuzzgqSoB3bAe8VcYPCvvk=pfBmLz4kmA5L8wGsTqPatuRg0w@mail.gmail.com>
References: <20191203202745.GR6962@tamriel.snowman.net>
<20200117212624.GA7872@alvherre.pgsql>
<CAOuzzgqSoB3bAe8VcYPCvvk=pfBmLz4kmA5L8wGsTqPatuRg0w@mail.gmail.com>
Stephen Frost <sfrost@snowman.net> writes:
> In particular- should we really be setting default privileges for objects
> that are being created by an extension, at all? The more I think about it,
> the less I like it, particularly when we start to think about the trusted
> extension work that Tom’s doing.
> In short, I’m leaning towards the argument that this was a missing check in
> the default ACL code to explicitly *not* add default privileges on objects
> that are being created by an extension. With such a check, the entire
> wouldn’t end up in pg_init_privs and the issue that started this thread
> wouldn’t happen.
Hmm. I think we'd still wish pg_upgrade to preserve whatever privileges
have been granted on extension objects, but that doesn't necessarily
have to happen through pg_init_privs. I've forgotten the details ---
would the change you suggest be enough to make upgrade work correctly,
or would we need additional hacking?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, sfrost@snowman.net, alvherre@2ndquadrant.com, FerdiSmit@optiver.com, florisvannee@optiver.com
Subject: Re: incorrect pg_dump output due to not handling dropped roles correctly
In-Reply-To: <32560.1580327205@sss.pgh.pa.us>
References: <20191203202745.GR6962@tamriel.snowman.net> <20200117212624.GA7872@alvherre.pgsql> <CAOuzzgqSoB3bAe8VcYPCvvk=pfBmLz4kmA5L8wGsTqPatuRg0w@mail.gmail.com> <32560.1580327205@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox