From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Jelte Fennema <postgres@jeltef.nl>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: duspensky@ya.ru
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16160: Minor memory leak in case of starting postgres server with SSL encryption
Date: Tue, 16 Mar 2021 14:03:34 -0400
Message-ID: <3376868.1615917814@sss.pgh.pa.us> (raw)
In-Reply-To: <20210316180109.ko6vqm7n4iovzryf@alap3.anarazel.de>
References: <16160-18367e56e9a28264@postgresql.org>
<20191213063915.GE1942@paquier.xyz>
<20191214092456.GB70616@paquier.xyz>
<CAGECzQTucR20CLwb6mw_JLdVST8GqYNqYr1OmAnNS2Byg8r+dg@mail.gmail.com>
<3255514.1615912277@sss.pgh.pa.us>
<20210316180109.ko6vqm7n4iovzryf@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2021-03-16 12:31:17 -0400, Tom Lane wrote:
>> I'm wondering about that because I see some other stuff in be_tls_init()
>> that looks like it might get leaked, notably the root_cert_list read
>> from the ssl_ca_file.
> Given that we're careful to destroy the "temporary" ssl context in case
> of error, perhaps the best way to deal with root_cert_list being freed
> in case of error would be to assign it to the context as soon as its
> loaded?
Yeah, I came to the same conclusion downthread. I'll go see about
making that happen.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, postgres@jeltef.nl, michael@paquier.xyz, duspensky@ya.ru, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16160: Minor memory leak in case of starting postgres server with SSL encryption
In-Reply-To: <3376868.1615917814@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox