pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Bossart, Nathan <bossartn@amazon.com>
To: Matthijs van der Vleuten <postgresql@zr40.nl>
To: Michael Paquier <michael@paquier.xyz>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Vik Fearing <vik@postgresfriends.org>
Cc: Alexander Korotkov <aekorotkov@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Subject: Re: BUG #17220: ALTER INDEX ALTER COLUMN SET (..) with an optionless opclass makes index and table unusable
Date: Tue, 19 Oct 2021 14:40:04 +0000
Message-ID: <34B9319E-8FF3-4303-A94D-BCDBCDC7ED2C@amazon.com> (raw)
In-Reply-To: <1ec02758-652e-48fa-afbf-c1d5ed5f06e2@www.fastmail.com>
References: <17220-15d684c6c2171a83@postgresql.org>
	<9b91d241-4d05-e5a4-67da-5b8acdb9a2f1@postgresfriends.org>
	<E29EF33B-CA1A-4146-BFCF-C8EC08FB91A8@amazon.com>
	<YWZViGJFJkrgBKwk@paquier.xyz>
	<CAFiTN-t9JSHmCtOtB_28BmAXEantUC2=1OKV_irAPAoxnzPadA@mail.gmail.com>
	<678CF71A-934B-4FD0-BF63-E41D795E41C9@amazon.com>
	<YWeQ2UXvXUH/Gt4T@paquier.xyz>
	<YW0mYDzpVhEjcbNp@paquier.xyz>
	<1ec02758-652e-48fa-afbf-c1d5ed5f06e2@www.fastmail.com>

On 10/18/21, 11:49 PM, "Matthijs van der Vleuten" <postgresql@zr40.nl> wrote:
> The test case doesn't seem entirely correct to me? The index being
> dropped (btree_tall_tbl_idx2) doesn't exist.

This was fixed before it was committed [0].

> Also, I don't believe this tests the case of dropping the index when
> it previously has been altered in this way.

That can still fail with the "has no options" ERROR, and fixing it
will still require a manual catalog update.  The ERROR is actually
coming from the call to index_open(), so bypassing it might require
some rather intrusive changes.  Given that it took over a year for
this bug to be reported, I suspect it might be more trouble than it's
worth.

Nathan

[0] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=fdd8857



view thread (16+ messages)  latest in thread

Message-ID: <34B9319E-8FF3-4303-A94D-BCDBCDC7ED2C@amazon.com>
Permalink:  ../34B9319E-8FF3-4303-A94D-BCDBCDC7ED2C@amazon.com/
Also on:    postgresql.org/message-id/34B9319E-8FF3-4303-A94D-BCDBCDC7ED2C@amazon.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: bossartn@amazon.com, postgresql@zr40.nl, michael@paquier.xyz, dilipbalaut@gmail.com, vik@postgresfriends.org, aekorotkov@gmail.com, pgsql-hackers@postgresql.org, robertmhaas@gmail.com
  Subject: Re: BUG #17220: ALTER INDEX ALTER COLUMN SET (..) with an optionless opclass makes index and table unusable
  In-Reply-To: <34B9319E-8FF3-4303-A94D-BCDBCDC7ED2C@amazon.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox