From: Michael Paquier <michael@paquier.xyz>
To: Bossart, Nathan <bossartn@amazon.com>
Cc: Matthijs van der Vleuten <postgresql@zr40.nl>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Vik Fearing <vik@postgresfriends.org>
Cc: Alexander Korotkov <aekorotkov@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Subject: Re: BUG #17220: ALTER INDEX ALTER COLUMN SET (..) with an optionless opclass makes index and table unusable
Date: Wed, 20 Oct 2021 12:47:04 +0900
Message-ID: <YW+ROCXCtFshHvDx@paquier.xyz> (raw)
In-Reply-To: <34B9319E-8FF3-4303-A94D-BCDBCDC7ED2C@amazon.com>
References: <17220-15d684c6c2171a83@postgresql.org>
<9b91d241-4d05-e5a4-67da-5b8acdb9a2f1@postgresfriends.org>
<E29EF33B-CA1A-4146-BFCF-C8EC08FB91A8@amazon.com>
<YWZViGJFJkrgBKwk@paquier.xyz>
<CAFiTN-t9JSHmCtOtB_28BmAXEantUC2=1OKV_irAPAoxnzPadA@mail.gmail.com>
<678CF71A-934B-4FD0-BF63-E41D795E41C9@amazon.com>
<YWeQ2UXvXUH/Gt4T@paquier.xyz>
<YW0mYDzpVhEjcbNp@paquier.xyz>
<1ec02758-652e-48fa-afbf-c1d5ed5f06e2@www.fastmail.com>
<34B9319E-8FF3-4303-A94D-BCDBCDC7ED2C@amazon.com>
On Tue, Oct 19, 2021 at 02:40:04PM +0000, Bossart, Nathan wrote:
> On 10/18/21, 11:49 PM, "Matthijs van der Vleuten" <postgresql@zr40.nl> wrote:
>> The test case doesn't seem entirely correct to me? The index being
>> dropped (btree_tall_tbl_idx2) doesn't exist.
>
> This was fixed before it was committed [0].
Yes, my apologies about this brain fade. The committed code is
hopefully fine :)
>> Also, I don't believe this tests the case of dropping the index when
>> it previously has been altered in this way.
>
> That can still fail with the "has no options" ERROR, and fixing it
> will still require a manual catalog update. The ERROR is actually
> coming from the call to index_open(), so bypassing it might require
> some rather intrusive changes. Given that it took over a year for
> this bug to be reported, I suspect it might be more trouble than it's
> worth.
This may need a mention in the release notes, but the problem is I
guess not that spread enough to worry or people would have complained
more since 13 was out. Logical dumps discard that automatically and
even for the ANALYZE case, the pre-committed code would have just
ignored the reloptions retrieved by get_attribute_options().
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, bossartn@amazon.com, postgresql@zr40.nl, dilipbalaut@gmail.com, vik@postgresfriends.org, aekorotkov@gmail.com, pgsql-hackers@postgresql.org, robertmhaas@gmail.com
Subject: Re: BUG #17220: ALTER INDEX ALTER COLUMN SET (..) with an optionless opclass makes index and table unusable
In-Reply-To: <YW+ROCXCtFshHvDx@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox