From: Bossart, Nathan <bossartn@amazon.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Vik Fearing <vik@postgresfriends.org>
Cc: postgresql@zr40.nl <postgresql@zr40.nl>
Cc: Alexander Korotkov <aekorotkov@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Subject: Re: BUG #17220: ALTER INDEX ALTER COLUMN SET (..) with an optionless opclass makes index and table unusable
Date: Mon, 18 Oct 2021 21:43:58 +0000
Message-ID: <355E7866-D1F3-4533-BE6C-17DBDA6A2ADD@amazon.com> (raw)
In-Reply-To: <YW0mYDzpVhEjcbNp@paquier.xyz>
References: <17220-15d684c6c2171a83@postgresql.org>
<9b91d241-4d05-e5a4-67da-5b8acdb9a2f1@postgresfriends.org>
<E29EF33B-CA1A-4146-BFCF-C8EC08FB91A8@amazon.com>
<YWZViGJFJkrgBKwk@paquier.xyz>
<CAFiTN-t9JSHmCtOtB_28BmAXEantUC2=1OKV_irAPAoxnzPadA@mail.gmail.com>
<678CF71A-934B-4FD0-BF63-E41D795E41C9@amazon.com>
<YWeQ2UXvXUH/Gt4T@paquier.xyz>
<YW0mYDzpVhEjcbNp@paquier.xyz>
On 10/18/21, 12:47 AM, "Michael Paquier" <michael@paquier.xyz> wrote:
> I have reviewed the last patch posted upthread, and while testing
> partitioned indexes I have noticed that we don't need to do a custom
> check as part of ATExecSetOptions(), because we have already that in
> ATSimplePermissions() with details on the relkind failing. This makes
> the patch simpler, with a better error message generated. I have
> added a case for partitioned indexes while on it.
Ah, yes, that is much better.
> Attached is the patch I am finishing with, that should go down to
> v13 (this is going to conflict on REL_13_STABLE, for sure).
+DROP INDEX btree_tall_tbl_idx2;
+ERROR: index "btree_tall_tbl_idx2" does not exist
I think this is supposed to be "btree_tall_idx2". Otherwise, the
patch looks reasonable to me.
Nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: bossartn@amazon.com, michael@paquier.xyz, dilipbalaut@gmail.com, vik@postgresfriends.org, postgresql@zr40.nl, aekorotkov@gmail.com, pgsql-hackers@postgresql.org, robertmhaas@gmail.com
Subject: Re: BUG #17220: ALTER INDEX ALTER COLUMN SET (..) with an optionless opclass makes index and table unusable
In-Reply-To: <355E7866-D1F3-4533-BE6C-17DBDA6A2ADD@amazon.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox