pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Regina Obe <lr@pcorp.us>
Cc: 'Heikki Linnakangas' <hlinnaka@iki.fi>
Cc: 'Juan José Santamaría Flecha' <juanjo.santamaria@gmail.com>
Cc: 'PostgreSQL mailing lists' <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16920: Can't compile PostGIS with MingW64 against PostgreSQL 14 head
Date: Fri, 19 Mar 2021 20:37:17 -0400
Message-ID: <362.1616200637@sss.pgh.pa.us> (raw)
In-Reply-To: <20210320001748.n5zkqsafuiwk7txp@alap3.anarazel.de>
References: <002d01d7183d$dda66420$98f32c60$@pcorp.us>
	<CAC+AXB1N24Av=TyzRp82Jb_ArZQ0LwamfHu-YwsOhYDFfYULdA@mail.gmail.com>
	<2730776.1615672184@sss.pgh.pa.us>
	<2735801.1615678739@sss.pgh.pa.us>
	<000d01d71869$2dabde70$89039b50$@pcorp.us>
	<0bf7c953-ea90-7c74-0f97-4e0e83d09dc9@iki.fi>
	<2850891.1615712! ! 197@sss.pgh.pa.us>
	<2 872301.1615744731@sss.pgh.pa.us>
	<000501d71932$7da0fa40$78e2eec0$@pcorp.us>
	<3009860.1615824779@sss.pgh.pa.us>
	<20210320001748.n5zkqsafuiwk7txp@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2021-03-15 12:12:59 -0400, Tom Lane wrote:
>> Although I remain worried about this being an ABI break, I don't think
>> we are locked into it until we get to beta, or maybe even RC stage.

> Could it make sense to define sigjmp_buf as a union over the potentially
> needed implementations? That'd allow us to switch back without an ABI
> break  if we discover a problem with the gcc approach.

No, it'd still be an ABI break, because the setjmp and the longjmp calls
have to use the same implementation.  Ain't gonna work if elog.c tries
to throw via mingw's longjmp() while some extension contains a PG_TRY
that uses __builtin_setjmp().  Nor vice versa.

			regards, tom lane





view thread (33+ messages)  latest in thread

Message-ID: <362.1616200637@sss.pgh.pa.us>
Permalink:  ../362.1616200637@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/362.1616200637@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, lr@pcorp.us, hlinnaka@iki.fi, juanjo.santamaria@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16920: Can't compile PostGIS with MingW64 against PostgreSQL 14 head
  In-Reply-To: <362.1616200637@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox