pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Atisss hh <125atishprak@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org, Peter Eisentraut <peter@eisentraut.org>
Subject: Re: BUG #19848: BEGIN ATOMIC with unnamed/OUT params breaks restore and pg_upgrade
Date: Thu, 12 Nov 2026 14:56:13 -0500
Message-ID: <362806.1794513373@sss.pgh.pa.us> (raw)
In-Reply-To: <CAGqfTttNfwC+m8o4LuD33jsHepROVVJMtHe4B8dm6YVTqoT+xQ@mail.gmail.com>
References: <19848-c4d5bc38ad4ab8b8@postgresql.org>
	<CAGqfTtueQf=MRh8hC3z7D6iATXDFfrz2WDLpPLrbpUV5K5CrAw@mail.gmail.com>
	<3773206.1794453200@sss.pgh.pa.us>
	<CAGqfTttNfwC+m8o4LuD33jsHepROVVJMtHe4B8dm6YVTqoT+xQ@mail.gmail.com>

Atisss hh <125atishprak@gmail.com> writes:
> I tested your patch on current master. All the cases from my report now
> create, dump and restore with identical results, and the core regression
> tests (243) and plsample pass. pg_upgrade from a patched build to a patched
> build works. Upgrading from 18.6 still fails with the empty identifier,
> since the old server does the deparsing, so this would also need
> backpatching to 18 to help pg_upgrade from there.

Yeah, it needs back-patching.  I did that and pushed it.

> Agreed that the q2 case is a scoping problem and not part of this bug.
> I don't have a better idea than printing $n, since any qualified name
> can be captured by a FROM item with the same name.

I'll wait to see if Peter has a better idea before doing anything
about that part.  The problem would only arise with a function name
that matches a table alias in some query within the function;
which is certainly possible but it must not be common, else we'd
have heard about this years ago.

			regards, tom lane






view thread (5+ messages)

Message-ID: <362806.1794513373@sss.pgh.pa.us>
Permalink:  ../362806.1794513373@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/362806.1794513373@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, 125atishprak@gmail.com, peter@eisentraut.org
  Subject: Re: BUG #19848: BEGIN ATOMIC with unnamed/OUT params breaks restore and pg_upgrade
  In-Reply-To: <362806.1794513373@sss.pgh.pa.us>
  References: <19848-c4d5bc38ad4ab8b8@postgresql.org> <CAGqfTtueQf=MRh8hC3z7D6iATXDFfrz2WDLpPLrbpUV5K5CrAw@mail.gmail.com> <3773206.1794453200@sss.pgh.pa.us> <CAGqfTttNfwC+m8o4LuD33jsHepROVVJMtHe4B8dm6YVTqoT+xQ@mail.gmail.com> <362806.1794513373@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox