From: Tom Lane <tgl@sss.pgh.pa.us>
To: David G. Johnston <david.g.johnston@gmail.com>
Cc: bokanist@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17840: Failing to execute auto_explain for logging leads to transaction rollback.
Date: Wed, 15 Mar 2023 18:06:25 -0400
Message-ID: <3632530.1678917985@sss.pgh.pa.us> (raw)
In-Reply-To: <CAKFQuwa2efAF3VWVVoSQBMUTYx3FsERx2y+o93yToEHL88kwzw@mail.gmail.com>
References: <17840-c480ed3600feea0e@postgresql.org>
<2558506.1678803048@sss.pgh.pa.us>
<CANtq+vQC+qqvrVeeLF3fnRRV28hpj0Vjz592Wxm8vYLFXvPZEA@mail.gmail.com>
<CAKFQuwa2efAF3VWVVoSQBMUTYx3FsERx2y+o93yToEHL88kwzw@mail.gmail.com>
"David G. Johnston" <david.g.johnston@gmail.com> writes:
> A query you can execute should be incapable of failing if EXPLAIN for the
> same query is issued.
Indeed. This should be especially true for auto_explain, which isn't
even doing a re-parse or re-plan, but just dumping data from the
executor state tree for the just-finished query. Barring edge cases
like out-of-memory, it really shouldn't fail; so I see no reason why
we should consider major structural changes to make it (perhaps) less
likely to fail.
I continue to think that the most likely explanation is oracle_fdw
doing something it probably shouldn't be doing. I have no interest
in poking into that code myself, though.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, david.g.johnston@gmail.com, bokanist@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17840: Failing to execute auto_explain for logging leads to transaction rollback.
In-Reply-To: <3632530.1678917985@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox