From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@2ndquadrant.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL Bugs <pgsql-bugs@postgresql.org>
Subject: Re: pg_upgrade < 9.3 -> >=9.3 misses a step around multixacts
Date: Mon, 21 Jul 2014 12:20:56 -0400
Message-ID: <3655.1405959656@sss.pgh.pa.us> (raw)
In-Reply-To: <20140721161222.GA17049@alap3.anarazel.de>
References: <20140720223010.GF5974@alap3.anarazel.de>
<17935.1405895946@sss.pgh.pa.us>
<20140720225653.GG5974@alap3.anarazel.de>
<18673.1405897470@sss.pgh.pa.us>
<18851.1405897900@sss.pgh.pa.us>
<20140720233125.GI5974@alap3.anarazel.de>
<19458.1405899435@sss.pgh.pa.us>
<20140720234925.GJ5974@alap3.anarazel.de>
<22178.1405903964@sss.pgh.pa.us>
<26504.1405912770@sss.pgh.pa.us>
<20140721161222.GA17049@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-bugs>
Andres Freund <andres@2ndquadrant.com> writes:
> 1) How about adding a elog(WARNING, "relation %u has invalid freeze
> limits", ...) to vac_update_datfrozenxid()? Otherwise it's a bit hard
> to understand what's going on. I wouldn't want to invest too much effort
> into the precision of the message, but some log bleat seems justified.
I considered that but wasn't really convinced it was a good idea.
You'd be getting a lot of log spam on a 9.3 installation that had
been affected by the pg_upgrade bug, until all the tables got cleaned
up (and we're intentionally not forcing that to happen quickly).
Anybody else have an opinion?
> 2) From a pedantic POV lastSane* should be initialized to
> ReadNewTransactionId()/ReadNextMultiXactId(). On a busy system we could
> otherwise consider concurrently updated values as being too new if some
> longrunning transaction finishes. Also GetOldestXmin() can sometimes go
> backwards...
If it's wrong then that's a pre-existing bug, but I don't think it's
wrong.
regards, tom lane
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@2ndquadrant.com, bruce@momjian.us, alvherre@2ndquadrant.com
Subject: Re: pg_upgrade < 9.3 -> >=9.3 misses a step around multixacts
In-Reply-To: <3655.1405959656@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox