pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: zedaardv@drizzle.com <zedaardv@drizzle.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17720: pg_dump creates a dump with primary key that cannot be restored, when specifying 'using index ...'
Date: Fri, 16 Dec 2022 11:12:17 -0500
Message-ID: <3682342.1671207137@sss.pgh.pa.us> (raw)
In-Reply-To: <9D3BC528-79FA-4440-9701-6CE8D9D90F41@yesql.se>
References: <17720-dab8ee0fa85d316d@postgresql.org>
	<CAKFQuwam=1NoSNH=EJRUnuuD8JE_jM8tq22-SYqO1nxzoXFwzg@mail.gmail.com>
	<9C039DE3-EFBD-4D65-B4CF-90D8148B7B4C@yesql.se>
	<2684951.1671032222@sss.pgh.pa.us>
	<20CD10FD-A9C2-47D0-9A75-B86532BC058E@yesql.se>
	<3039077.1671060472@sss.pgh.pa.us>
	<173834de-18a1-4a9c-5e15-9b22e56c4293@enterprisedb.com>
	<9D3BC528-79FA-4440-9701-6CE8D9D90F41@yesql.se>

Daniel Gustafsson <daniel@yesql.se> writes:
> The attached removes the change from pg_dump and only prohibits the ALTER TABLE
> command for attaching the index.  Since it will render dumps unable to be
> restored I also added a check to pg_upgrade to cover the case.

That doesn't seem like a great answer.  I understood Peter to be
favoring both aspects of the previous patch.

			regards, tom lane





view thread (22+ messages)  latest in thread

Message-ID: <3682342.1671207137@sss.pgh.pa.us>
Permalink:  ../3682342.1671207137@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3682342.1671207137@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, peter.eisentraut@enterprisedb.com, david.g.johnston@gmail.com, zedaardv@drizzle.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17720: pg_dump creates a dump with primary key that cannot be restored, when specifying 'using index ...'
  In-Reply-To: <3682342.1671207137@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox