pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Barton <barton.tomas@gmail.com>
Cc: pgsql-bugs@postgresql.org
Subject: Re: pg_upgrade --check doesn't check pg_pltemplate modifications
Date: Sun, 16 Jan 2022 11:43:14 -0500
Message-ID: <3704260.1642351394@sss.pgh.pa.us> (raw)
In-Reply-To: <CAPV2KRg3752VbyjTtkEeACNbqRtT82TqsMfioo4nVgY8U+Cs=Q@mail.gmail.com>
References: <CAPV2KRg3752VbyjTtkEeACNbqRtT82TqsMfioo4nVgY8U+Cs=Q@mail.gmail.com>

Tomas Barton <barton.tomas@gmail.com> writes:
> Any non-default GRANT/REVOKE like these:

> REVOKE SELECT ON TABLE "pg_catalog"."pg_pltemplate" FROM PUBLIC;
> GRANT SELECT ON TABLE "pg_catalog"."pg_pltemplate" TO "reader";

Uh ... why would you do that?  It seems only academically
different from randomly deleting some catalog entries.

> would break the upgrade process, even though the pg_upgrade --check says:
> *Clusters are compatible*

pg_upgrade has never promised to detect every possible problem.
Considering that pg_pltemplate is gone entirely in v13 and up,
I doubt we're going to want to invest a lot of effort here.

			regards, tom lane





view thread (2+ messages)

Message-ID: <3704260.1642351394@sss.pgh.pa.us>
Permalink:  ../3704260.1642351394@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3704260.1642351394@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, barton.tomas@gmail.com
  Subject: Re: pg_upgrade --check doesn't check pg_pltemplate modifications
  In-Reply-To: <3704260.1642351394@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox