From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Andrey Rachitskiy <pl0h0yp1@gmail.com>
Cc: ilia.kashintsev@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #19613: pg_restore: several SEGVs in ReadToc() in pg_backup_archiver.c
Date: Fri, 14 Aug 2026 12:33:07 -0400
Message-ID: <3767380.1786725187@sss.pgh.pa.us> (raw)
In-Reply-To: <09D266FA-E7FE-4816-B5A3-EEF13140D7F0@yandex-team.ru>
References: <19613-3a9ffc23ee402382@postgresql.org>
<CAB8bMisXgPyHXQeiPTbemp_uANRXPUgyytbDsMfywJGyAqvDOA@mail.gmail.com>
<09D266FA-E7FE-4816-B5A3-EEF13140D7F0@yandex-team.ru>
Andrey Borodin <x4mmm@yandex-team.ru> writes:
> Could we add a regression test?
-1 ... I think the engineering, maintenance, and runtime cost of a
test like this would never pay for itself. The thing you would wish
that a regression test could catch is adding a new TOC field that is
effectively required while failing to use ReadRequiredStr for it.
Which a test like this wouldn't.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, x4mmm@yandex-team.ru, pl0h0yp1@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19613: pg_restore: several SEGVs in ReadToc() in pg_backup_archiver.c
In-Reply-To: <3767380.1786725187@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox