pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Dmitry Astapov <dastapov@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17619: AllocSizeIsValid violation in parallel hash join
Date: Tue, 27 Sep 2022 12:44:40 -0400
Message-ID: <3802603.1664297080@sss.pgh.pa.us> (raw)
In-Reply-To: <CAH2-WzknY8v7CWP-qZB071_i-QP7MpTYFxAkrmR_r3LZRc9CLQ@mail.gmail.com>
References: <17619-0de62ceda812b8b5@postgresql.org>
	<CA+hUKGKu3xSP7JsRGHw0d2Lxe_e4Y-3bf_1dkgAZj7xcsG=q1w@mail.gmail.com>
	<CAFQUnFiiPUOWihzjH7gevyaGGnX3tskr_3YFtNhv-AzpzY-jrg@mail.gmail.com>
	<CAFQUnFgvgfnwrPQ8j4DSeAHUoZy=FbG9nhBCakrnUQ8KuyRZJg@mail.gmail.com>
	<CAFQUnFhEFTaMafweOG2P7FNToLeiDFrsYRfSBk7TrrkTv+3fMA@mail.gmail.com>
	<CA+hUKGL1OuDjd5EipFwUnKxKUTWZLhLssBHLOj4Vzo46M9XCYw@mail.gmail.com>
	<2169849.1663975173@sss.pgh.pa.us>
	<CAH2-Wzk+wEsNxXJwt=jHpExbBFh+vLnyfJ7CcNqMmnGkiQvFKw@mail.gmail.com>
	<CAH2-Wzks9HkNoBWdFhB0Q8uT4JOw2mcYJ5Sm7Ara_NutTHLs8A@mail.gmail.com>
	<CAH2-Wz=+K9K+RYKLyDbPsp_gKfM_2YS-8zU4NxDY+EJ132cLMw@mail.gmail.com>
	<3800397.1664295848@sss.pgh.pa.us>
	<CAH2-WzknY8v7CWP-qZB071_i-QP7MpTYFxAkrmR_r3LZRc9CLQ@mail.gmail.com>

Peter Geoghegan <pg@bowt.ie> writes:
> On Tue, Sep 27, 2022 at 9:24 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I think I'd personally prefer to treat such memory more like we
>> treat palloc'd memory, ie there's *not* a guarantee of zero
>> initialization and indeed testing builds intentionally clobber it.

> Isn't that already how it works? The problem is that it's not
> particularly clear that that's how it works right now. And that the
> dynamic shared memory stuff isn't tested via the same techniques that
> we use for palloc.

Right, the missing piece is the intentional clobber.  Thomas indicated
he'd made such a test locally, but I think it needs full support with
the same options that mcxt.c has (CLOBBER_FREED_MEMORY and so on
--- although unmapping the memory is equally good for that, if we
always do it).

			regards, tom lane





view thread (21+ messages)  latest in thread

Message-ID: <3802603.1664297080@sss.pgh.pa.us>
Permalink:  ../3802603.1664297080@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3802603.1664297080@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pg@bowt.ie, thomas.munro@gmail.com, dastapov@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17619: AllocSizeIsValid violation in parallel hash join
  In-Reply-To: <3802603.1664297080@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox