pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jan Nidzwetzki <jan@planetscale.com>
To: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Cc: ♂π≌26218 <1991230470@qq.com>
Cc: pgsql-bugs <pgsql-bugs@lists.postgresql.org>
Subject: Re: START_REPLICATION silently truncates an overlong LSN component
Date: Mon, 26 Oct 2026 16:26:55 +0100
Message-ID: <39e2b3b2-aa68-4e8d-832e-6e3904e9bea7@planetscale.com> (raw)
In-Reply-To: <OS7PR01MB18317955E3D7441FB5BEDC77FF5612@OS7PR01MB18317.jpnprd01.prod.outlook.com>
References: <tencent_C6ED19DF1759CDD37E786F7EE0B5207D0009@qq.com>
	<CAJTYsWWN82LQzaVPX4D-P_yhooMf18OZ_6uO7jxdbrMaq1KexA@mail.gmail.com>
	<OS9PR01MB1214972D4AF13C0B23FB2129EF5BE2@OS9PR01MB12149.jpnprd01.prod.outlook.com>
	<8b1abbd0-7335-4e68-93ec-91cdbbfd9568@planetscale.com>
	<OS7PR01MB18317EED85B1A72C69B226630F5672@OS7PR01MB18317.jpnprd01.prod.outlook.com>
	<CAHGQGwF1VdMww-2s4To3W14Gw48-=4=aUWDyw-ER5WTVm0RTBA@mail.gmail.com>
	<OS7PR01MB183171391E7DA9DB9DBDEF419F5672@OS7PR01MB18317.jpnprd01.prod.outlook.com>
	<CAHGQGwFJs1Kb3kqpatk-=d2M5g=7yar+dyrDiqNYYVFf-F3-rQ@mail.gmail.com>
	<OS7PR01MB1831746179FE303840ABEDBD4F5662@OS7PR01MB18317.jpnprd01.prod.outlook.com>
	<CAHGQGwEcR5vUL7CFrYSSKAW9Cba9o-b=EsoNjqCU_6iuz+rwTA@mail.gmail.com>
	<OS7PR01MB1831703F6C7FD5F783A0B7F6EF5642@OS7PR01MB18317.jpnprd01.prod.outlook.com>
	<CAHGQGwF97J+RLnz1gewoM6Sh2XbsEHAm=ytgeUPqD8xoTB6xXQ@mail.gmail.com>
	<OS7PR01MB18317955E3D7441FB5BEDC77FF5612@OS7PR01MB18317.jpnprd01.prod.outlook.com>

Hi Kuroda-san, Fujii-san,

Thanks for updating the patch set. I tested the two remaining ones on my
system. They apply cleanly and check-world passes.

Patch 0001
==========

I have just a small comment on the moved MAXPG_LSNLEN. It's currently a
hard-coded 17. It could make sense to export MAXPG_LSNCOMPONENT as well
and define MAXPG_LSNLEN as (2 * MAXPG_LSNCOMPONENT + 1), which would
document where the value comes from.

Patch 0002
==========

Kuroda-san wrote in the v5 mail:

> I also attached the test code to check invalid strings can be
rejected, see 0002.
> I'm not intended to be pushed.

I think this test is worth committing. As far as I can see, nothing else
covers the "this is an incremental backup, not a data directory" error,
and the new LSN checks would otherwise remain untested. However, we test
only an overlong high component. It could make sense to add this test
for the low component as well (e.g., using 0/123456789).

Best regards
  Jan

-- 
Jan Nidzwetzki
PlanetScale Postgres Core Team







view thread (20+ messages)  latest in thread

Message-ID: <39e2b3b2-aa68-4e8d-832e-6e3904e9bea7@planetscale.com>
Permalink:  ../39e2b3b2-aa68-4e8d-832e-6e3904e9bea7@planetscale.com/
Also on:    postgresql.org/message-id/39e2b3b2-aa68-4e8d-832e-6e3904e9bea7@planetscale.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: jan@planetscale.com, kuroda.hayato@fujitsu.com, masao.fujii@gmail.com, ayushtiwari.slg01@gmail.com, 1991230470@qq.com
  Subject: Re: START_REPLICATION silently truncates an overlong LSN component
  In-Reply-To: <39e2b3b2-aa68-4e8d-832e-6e3904e9bea7@planetscale.com>
  References: <tencent_C6ED19DF1759CDD37E786F7EE0B5207D0009@qq.com> <OS9PR01MB1214972D4AF13C0B23FB2129EF5BE2@OS9PR01MB12149.jpnprd01.prod.outlook.com> <8b1abbd0-7335-4e68-93ec-91cdbbfd9568@planetscale.com> <OS7PR01MB18317EED85B1A72C69B226630F5672@OS7PR01MB18317.jpnprd01.prod.outlook.com> <CAHGQGwF1VdMww-2s4To3W14Gw48-=4=aUWDyw-ER5WTVm0RTBA@mail.gmail.com> <OS7PR01MB183171391E7DA9DB9DBDEF419F5672@OS7PR01MB18317.jpnprd01.prod.outlook.com> <CAHGQGwFJs1Kb3kqpatk-=d2M5g=7yar+dyrDiqNYYVFf-F3-rQ@mail.gmail.com> <OS7PR01MB1831746179FE303840ABEDBD4F5662@OS7PR01MB18317.jpnprd01.prod.outlook.com> <CAHGQGwEcR5vUL7CFrYSSKAW9Cba9o-b=EsoNjqCU_6iuz+rwTA@mail.gmail.com> <OS7PR01MB1831703F6C7FD5F783A0B7F6EF5642@OS7PR01MB18317.jpnprd01.prod.outlook.com> <CAHGQGwF97J+RLnz1gewoM6Sh2XbsEHAm=ytgeUPqD8xoTB6xXQ@mail.gmail.com> <OS7PR01MB18317955E3D7441FB5BEDC77FF5612@OS7PR01MB18317.jpnprd01.prod.outlook.com> <39e2b3b2-aa68-4e8d-832e-6e3904e9bea7@planetscale.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox