pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: David Steele <david@pgmasters.net>
To: Pavel Suderevsky <psuderevsky@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: Don't try fetching future segment of a TLI.
Date: Tue, 7 Apr 2020 12:15:00 +0900
Message-ID: <3e0713d2-56d2-9883-4213-d5ba7f0dcabf@oss.nttdata.com> (raw)
In-Reply-To: <762ffb60-df9c-0efc-2714-9859219157e3@pgmasters.net>
References: <16159-f5a34a3a04dc67e0@postgresql.org>
	<20191212.124856.202839248708529678.horikyota.ntt@gmail.com>
	<CAEBTBzsi8HrTTSC1xwL0otzrwdefRSLuwdQ7LnAs+jQeN+EJ8A@mail.gmail.com>
	<20200129.120222.1476610231001551715.horikyota.ntt@gmail.com>
	<8c831a30-a3a2-de89-2059-e7ce842d7aed@pgmasters.net>
	<CAEBTBzupObE6Gep1y-ajvUh4AjuvyTmfTewshVOei12uRV=Q8Q@mail.gmail.com>
	<792ea085-95c4-bca0-ae82-47fdc80e146d@oss.nttdata.com>
	<762ffb60-df9c-0efc-2714-9859219157e3@pgmasters.net>



On 2020/04/07 4:04, David Steele wrote:
> On 4/6/20 1:43 PM, Fujii Masao wrote:
>>
>>
>> On 2020/03/19 22:22, Pavel Suderevsky wrote:
>>> Hi,
>>>
>>> I've tested patch provided by Kyotaro and do confirm it fixes the issue.
>>
>> The patch looks good to me. Attached is the updated version of the patch.
>> I updated only comments.
>>
>> Barring any objection, I will commit this patch.
> 
> The patch looks good to me.
> 
>>> Any chance it will be merged to one of the next minor releases?
>>
>> This doesn't seem a bug, so I'm thinking to merge this to next *major*
>> version release, i.e., v13.
> 
> Not a bug, perhaps, but I think we do consider back-patching performance problems. The rise in S3 usage has just exposed how poorly this performed code in high-latency environments.

I understood the situation and am fine to back-patch that. But I'm not sure
if it's fair to do that. Maybe we need to hear more opinions about this?
OTOH, feature freeze for v13 is today, so what about committing the patch
in v13 at first, and then doing the back-patch after hearing opinions and
receiving many +1?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION





view thread (13+ messages)  latest in thread

Message-ID: <3e0713d2-56d2-9883-4213-d5ba7f0dcabf@oss.nttdata.com>
Permalink:  ../3e0713d2-56d2-9883-4213-d5ba7f0dcabf@oss.nttdata.com/
Also on:    postgresql.org/message-id/3e0713d2-56d2-9883-4213-d5ba7f0dcabf@oss.nttdata.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, david@pgmasters.net, psuderevsky@gmail.com, horikyota.ntt@gmail.com, pgsql-hackers@lists.postgresql.org, pgsql-bugs@lists.postgresql.org
  Subject: Re: Don't try fetching future segment of a TLI.
  In-Reply-To: <3e0713d2-56d2-9883-4213-d5ba7f0dcabf@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox