From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Yuli Khodorkovskiy <yuli.khodorkovskiy@crunchydata.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15804: Assertion failure when using logging_collector with EXEC_BACKEND
Date: Wed, 11 Sep 2019 11:47:07 -0400
Message-ID: <4024.1568216827@sss.pgh.pa.us> (raw)
In-Reply-To: <20190911021641.GC1953@paquier.xyz>
References: <16df9d01-8b03-2664-a18c-16c40186f5ab@2ndQuadrant.com>
<2702.1558289980@sss.pgh.pa.us>
<20190520012728.GC1923@paquier.xyz>
<1664.1558325417@sss.pgh.pa.us>
<7927.1558364465@sss.pgh.pa.us>
<31457.1568057723@sss.pgh.pa.us>
<20190910051115.GB22934@paquier.xyz>
<6728.1568093331@sss.pgh.pa.us>
<20190910053923.GC11737@paquier.xyz>
<20705.1568127532@sss.pgh.pa.us>
<20190911021641.GC1953@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Sep 10, 2019 at 10:58:52AM -0400, Tom Lane wrote:
>> Here's a version that does it like that. After studying things a bit,
>> it seemed like a good idea to also move RemovePgTempFiles() down,
>> so that that possibly-slow step still occurs after making the external
>> PID file. Everything else that we've moved to before that step
>> should be reasonably quick.
> Good point. Nothing more to add with this version. Thanks for
> caring.
I did one final round of testing and noted that in a Linux EXEC_BACKEND
build, this last change causes the race condition that was noted upthread:
RemovePgTempFiles could remove the parameter file that the syslogger
process is supposed to consume. So I split off the clearing of that
subdirectory as we'd discussed, and pushed it. Thanks for reviewing!
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, andrew.dunstan@2ndquadrant.com, andres@anarazel.de, peter.eisentraut@2ndquadrant.com, yuli.khodorkovskiy@crunchydata.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15804: Assertion failure when using logging_collector with EXEC_BACKEND
In-Reply-To: <4024.1568216827@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox