From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Yuli Khodorkovskiy <yuli.khodorkovskiy@crunchydata.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15804: Assertion failure when using logging_collector with EXEC_BACKEND
Date: Tue, 10 Sep 2019 14:39:23 +0900
Message-ID: <20190910053923.GC11737@paquier.xyz> (raw)
In-Reply-To: <6728.1568093331@sss.pgh.pa.us>
References: <22995.1558278322@sss.pgh.pa.us>
<27719.1558282181@sss.pgh.pa.us>
<16df9d01-8b03-2664-a18c-16c40186f5ab@2ndQuadrant.com>
<2702.1558289980@sss.pgh.pa.us>
<20190520012728.GC1923@paquier.xyz>
<1664.1558325417@sss.pgh.pa.us>
<7927.1558364465@sss.pgh.pa.us>
<31457.1568057723@sss.pgh.pa.us>
<20190910051115.GB22934@paquier.xyz>
<6728.1568093331@sss.pgh.pa.us>
On Tue, Sep 10, 2019 at 01:28:51AM -0400, Tom Lane wrote:
> But the external PID file is a different story. I can believe that
> something might be expecting the sockets to be open before we create
> that file --- and since we're not using that file for an interlock,
> there's no reason to be in a hurry to create it. I think it'd make
> sense to move that step further down, so it's still done after the
> create-sockets step.
That's the actual take here. We cannot assume that nobody is relying
on that. If they do, it could be tricky to rework this logic. Moving
the external file write a bit later does not sound like a bad thing in
itself to keep more consistency with the past.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20190910053923.GC11737@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, andrew.dunstan@2ndquadrant.com, andres@anarazel.de, peter.eisentraut@2ndquadrant.com, yuli.khodorkovskiy@crunchydata.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15804: Assertion failure when using logging_collector with EXEC_BACKEND
In-Reply-To: <20190910053923.GC11737@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox