pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: postgresql@taljaren.se, pgsql-hackers@lists.postgresql.org, Michael Paquier <michael@paquier.xyz>
Subject: Re: BUG #17717: Regression in vacuumdb (15 is slower than 10/11 and possible memory issue)
Date: Wed, 28 Dec 2022 17:05:39 -0500
Message-ID: <424445.1672265139@sss.pgh.pa.us> (raw)
In-Reply-To: <20221228212150.GA4009813@nathanxps13>
References: <17717-6c50eb1c7d23a886@postgresql.org>
	<3439037.1671130590@sss.pgh.pa.us>
	<CAH2-Wzne4Wgaaruq-VSY2qWNhxcPRqWUbdwVQPkM81TpaHY_kQ@mail.gmail.com>
	<3544447.1671141436@sss.pgh.pa.us>
	<CAH2-WzkXmYt-K+pQqMqjFgwU7jiykD3amngd5-jkqQF=gST7Og@mail.gmail.com>
	<3672943.1671202149@sss.pgh.pa.us>
	<CAH2-WzkHRxcE-0Mub9N0Rr09SGEEF1Ex4pUbcOBSRoNGNVy93w@mail.gmail.com>
	<407579.1672258403@sss.pgh.pa.us>
	<20221228212150.GA4009813@nathanxps13>

Nathan Bossart <nathandbossart@gmail.com> writes:
> On Wed, Dec 28, 2022 at 03:13:23PM -0500, Tom Lane wrote:
>> +		executeCommand(conn, "VACUUM (ONLY_DATABASE_STATS);", echo);

> When I looked at this, I thought it would be better to send the command
> through the parallel slot machinery so that failures would use the same
> code path as the rest of the VACUUM commands.  However, you also need to
> adjust ParallelSlotsWaitCompletion() to mark the slots as idle so that the
> slot array can be reused after it is called.

Hm.  I was just copying the way commands are issued further up in the
same function.  But I think you're right: once we've done

	ParallelSlotsAdoptConn(sa, conn);

it's probably not entirely kosher to use the conn directly.

			regards, tom lane





view thread (29+ messages)  latest in thread

Message-ID: <424445.1672265139@sss.pgh.pa.us>
Permalink:  ../424445.1672265139@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/424445.1672265139@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, nathandbossart@gmail.com, pg@bowt.ie, michael@paquier.xyz
  Subject: Re: BUG #17717: Regression in vacuumdb (15 is slower than 10/11 and possible memory issue)
  In-Reply-To: <424445.1672265139@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox