agora inbox for pgsql-bugs@postgresql.org
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: Ewan Young <kdbase.hack@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: Andrey Rachitskiy <pl0h0yp1@gmail.com>
Cc: michaelmalis2@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19595: Three memory-safety defects in src/backend/tsearch/spell.c (dictionary loader), PG 18.3
Date: Sat, 29 Aug 2026 20:14:57 -0400
Message-ID: <431728.1788048897@sss.pgh.pa.us> (raw)
In-Reply-To: <CAON2xHN3QmsaySM6DGWa1gttcbJoFh0wjAE-_ZpSPo=LKN1hYw@mail.gmail.com>
References: <19595-7dc18b4e212c4757@postgresql.org>
<CAB8bMiun+cTqTnv-cTfxvTbnOLxWunRgyZeUZ88YMSLLXub4mg@mail.gmail.com>
<325748.1785691547@sss.pgh.pa.us>
<0f3ddeb5-0dbd-479c-9d0e-ae254758e624@gmail.com>
<336527.1785701494@sss.pgh.pa.us>
<CAON2xHN3QmsaySM6DGWa1gttcbJoFh0wjAE-_ZpSPo=LKN1hYw@mail.gmail.com>
Ewan Young <kdbase.hack@gmail.com> writes:
> One more problem in the same file. It is not one of the three in the
> original report - those were all on the affix-rule side (CompoundAffix,
> the flag buffer, the AF alias table), while this one is in the compound
> flag table - and it is older than all of them, the code being from 9.6.
> So I'm posting here rather than opening a new report.
Pushed, thanks for the report!
I noticed while reading your patch that all of the strtol() calls in
this file store the result into an "int" not a "long", which opens
the door to an undetected integer overflow and truncation. Nothing
terribly harmful seems likely to ensue, but I thought I'd clean that
up too while we're here.
regards, tom lane
view thread (15+ messages) latest in thread
Message-ID: <431728.1788048897@sss.pgh.pa.us>
Permalink: ../431728.1788048897@sss.pgh.pa.us/
Also on: postgresql.org/message-id/431728.1788048897@sss.pgh.pa.us
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, kdbase.hack@gmail.com, exclusion@gmail.com, pl0h0yp1@gmail.com, michaelmalis2@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19595: Three memory-safety defects in src/backend/tsearch/spell.c (dictionary loader), PG 18.3
In-Reply-To: <431728.1788048897@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox