From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: David Rowley <david.rowley@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: ND Abelisto <abelisto@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15343: Segmentation fault using pg_dump with --exclude-table if table contains identity column
Date: Tue, 21 Aug 2018 15:01:49 +0200
Message-ID: <45913d0f-d395-3099-9dff-20fc8316848c@2ndquadrant.com> (raw)
In-Reply-To: <CAKJS1f-5m+RXkRQbGh7AKng5mcW_68aP9uytHKCP5bFyRmBJDQ@mail.gmail.com>
References: <CAKJS1f_RzF8s5Osi2ae3fMMnBOv=zZSw51OJ1iPur=07d0Sw-w@mail.gmail.com>
<20180821011949.r5ogh32qluf56na6@alvherre.pgsql>
<20180821014944.GC2897@paquier.xyz>
<CAKJS1f--xFQtVr61nCxZ1CUCuvu9TkBonCVVeUhyqrE=rkEmpA@mail.gmail.com>
<CAKJS1f-5m+RXkRQbGh7AKng5mcW_68aP9uytHKCP5bFyRmBJDQ@mail.gmail.com>
On 21/08/2018 13:12, David Rowley wrote:
> On 21 August 2018 at 17:46, David Rowley <david.rowley@2ndquadrant.com> wrote:
>> On 21 August 2018 at 13:49, Michael Paquier <michael@paquier.xyz> wrote:
>>> I was just looking at this issue, or both of you are already on it?
>>
>> It's already in my head what it should look like, so I can write it,
>> although it might not appear until tomorrow, as I've reached the end
>> of my day now.
>
> I've attached what I had in mind. The header comment for
> getOwnedSeqs() gives me the impression this is the best place to
> locate this code.
Yes, that looks good to me.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, david.rowley@2ndquadrant.com, michael@paquier.xyz, alvherre@2ndquadrant.com, abelisto@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15343: Segmentation fault using pg_dump with --exclude-table if table contains identity column
In-Reply-To: <45913d0f-d395-3099-9dff-20fc8316848c@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox