pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: exclusion@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17056: Segmentation fault on altering the type of the foreign table column with a default
Date: Thu, 10 Jun 2021 18:55:05 -0400
Message-ID: <4726f847-68fb-a7fc-c5e9-7b9536046fc4@dunslane.net> (raw)
In-Reply-To: <1806408.1623363029@sss.pgh.pa.us>
References: <17056-4f6f7243d322be6b@postgresql.org>
	<1806408.1623363029@sss.pgh.pa.us>


On 6/10/21 6:10 PM, Tom Lane wrote:
> PG Bug reporting form <noreply@postgresql.org> writes:
>> CREATE FOREIGN DATA WRAPPER dummy;
>> CREATE SERVER s0 FOREIGN DATA WRAPPER dummy;
>> CREATE FOREIGN TABLE ft1 (c1 integer NOT NULL) SERVER s0;
>> ALTER FOREIGN TABLE ft1 ADD COLUMN c8 integer DEFAULT 0;
>> ALTER FOREIGN TABLE ft1 ALTER COLUMN c8 TYPE char(10);
> Hmm.  The equivalent DDL on a plain table works fine, but this is
> crashing in the code that manipulates attmissingval.  I suspect some
> confusion about whether a foreign table column should even *have*
> attmissingval.  Andrew, any thoughts?
>
> 			


My initial thought would be that it should not. If the foreign table has
rows with missing columns then it should be up to the foreign server to
supply them transparently. We have no notion what the foreign semantics
of missing columns are.


I can take a look at a fix tomorrow. My inclination would be simply to
skip setting attmissingval for foreign tables.


cheers


andrew



--
Andrew Dunstan
EDB: https://www.enterprisedb.com






view thread (12+ messages)  latest in thread

Message-ID: <4726f847-68fb-a7fc-c5e9-7b9536046fc4@dunslane.net>
Permalink:  ../4726f847-68fb-a7fc-c5e9-7b9536046fc4@dunslane.net/
Also on:    postgresql.org/message-id/4726f847-68fb-a7fc-c5e9-7b9536046fc4@dunslane.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: andrew@dunslane.net, tgl@sss.pgh.pa.us, exclusion@gmail.com
  Subject: Re: BUG #17056: Segmentation fault on altering the type of the foreign table column with a default
  In-Reply-To: <4726f847-68fb-a7fc-c5e9-7b9536046fc4@dunslane.net>
  References: <17056-4f6f7243d322be6b@postgresql.org> <1806408.1623363029@sss.pgh.pa.us> <4726f847-68fb-a7fc-c5e9-7b9536046fc4@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox