From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dilyan Palauzov <Dilyan.Palauzov@aegee.org>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: No libldap_r in OpenLDAP 2.5 - use LDAP_API_FEATURE_X_OPENLDAP_REENTRANT from ldap_features.h
Date: Wed, 25 Aug 2021 02:29:38 -0400
Message-ID: <520273.1629872978@sss.pgh.pa.us> (raw)
In-Reply-To: <20210825052142.Horde.fX47Irhz5YmXoRVbIbyYUJm@webmail.aegee.org>
References: <20210825052142.Horde.fX47Irhz5YmXoRVbIbyYUJm@webmail.aegee.org>
Dilyan Palauzov <Dilyan.Palauzov@aegee.org> writes:
> The current postgres/configure.ac logic is: if libldap_r is availabe,
> then use it, otherwise use libldap.
Right.
> I propose, instead of looking for the presence of libldap_r, to check
> the feature macro, and if libldap is reentrant, not to use libldap_r .
Why? This seems more fragile (i.e., it adds an assumption that the
visible header file matches the available libraries), and if there is
a concrete benefit, you did not say what that is.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, Dilyan.Palauzov@aegee.org, pgsql-bugs@lists.postgresql.org
Subject: Re: No libldap_r in OpenLDAP 2.5 - use LDAP_API_FEATURE_X_OPENLDAP_REENTRANT from ldap_features.h
In-Reply-To: <520273.1629872978@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox