pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Haribabu Kommi <kommi.haribabu@gmail.com>
Cc: nickbarnes01@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15310: pg_upgrade dissociates event triggers from extensions
Date: Tue, 07 Aug 2018 16:38:03 -0400
Message-ID: <5239.1533674283@sss.pgh.pa.us> (raw)
In-Reply-To: <20180807112910.GB19883@paquier.xyz>
References: <153360083872.1395.4593932457718151600@wrigleys.postgresql.org>
	<CAJrrPGcNzZ1n-xNsRfpxt=c_vYWnDK7hd_z80p4G8Tr1G15wAA@mail.gmail.com>
	<20180807112910.GB19883@paquier.xyz>

Michael Paquier <michael@paquier.xyz> writes:
> That sounds like a bug to me.  Could you add more tests to
> src/test/modules/test_pg_dump with an event trigger part of an extension
> with a binary upgrade test?

It doesn't seem especially useful to me to lock this particular barn
door behind the horse.  What would be great is a way of cross-checking
that the grammar, pg_dump, and the various callers of
recordDependencyOnCurrentExtension are all on the same page about
which objects can be extension members.  I see no way to automate that
unfortunately :-(

			regards, tom lane




view thread (5+ messages)

Message-ID: <5239.1533674283@sss.pgh.pa.us>
Permalink:  ../5239.1533674283@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/5239.1533674283@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, kommi.haribabu@gmail.com, nickbarnes01@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15310: pg_upgrade dissociates event triggers from extensions
  In-Reply-To: <5239.1533674283@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox