pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: feikesteenbergen@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15555: Syntax errors when using the COMMENT command in plpgsql and a "comment" variable
Date: Fri, 4 Jan 2019 15:09:48 +0100
Message-ID: <52614d45-ca8d-5682-d532-8d1f2f2dbd9c@2ndquadrant.com> (raw)
In-Reply-To: <23647.1545084358@sss.pgh.pa.us>
References: <15555-149bbd70ddc7b4b6@postgresql.org>
	<31368.1545078376@sss.pgh.pa.us>
	<32114.1545079626@sss.pgh.pa.us>
	<23647.1545084358@sss.pgh.pa.us>

On 17/12/2018 23:05, Tom Lane wrote:
> [ pokes at that for a bit ]  The logic here is a bit denser than
> one could wish, but here's a draft patch that seems to get the
> job done.  It passes check-world, which isn't conclusive but
> at least suggests that this doesn't break anything.

This looks good to me.  I can't think of any other syntax scenarios that
it needs to address.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




view thread (6+ messages)  latest in thread

Message-ID: <52614d45-ca8d-5682-d532-8d1f2f2dbd9c@2ndquadrant.com>
Permalink:  ../52614d45-ca8d-5682-d532-8d1f2f2dbd9c@2ndquadrant.com/
Also on:    postgresql.org/message-id/52614d45-ca8d-5682-d532-8d1f2f2dbd9c@2ndquadrant.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, feikesteenbergen@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15555: Syntax errors when using the COMMENT command in plpgsql and a "comment" variable
  In-Reply-To: <52614d45-ca8d-5682-d532-8d1f2f2dbd9c@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox