From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: feikesteenbergen@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15555: Syntax errors when using the COMMENT command in plpgsql and a "comment" variable
Date: Fri, 04 Jan 2019 12:18:24 -0500
Message-ID: <7799.1546622304@sss.pgh.pa.us> (raw)
In-Reply-To: <52614d45-ca8d-5682-d532-8d1f2f2dbd9c@2ndquadrant.com>
References: <15555-149bbd70ddc7b4b6@postgresql.org>
<31368.1545078376@sss.pgh.pa.us>
<32114.1545079626@sss.pgh.pa.us>
<23647.1545084358@sss.pgh.pa.us>
<52614d45-ca8d-5682-d532-8d1f2f2dbd9c@2ndquadrant.com>
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 17/12/2018 23:05, Tom Lane wrote:
>> [ pokes at that for a bit ] The logic here is a bit denser than
>> one could wish, but here's a draft patch that seems to get the
>> job done. It passes check-world, which isn't conclusive but
>> at least suggests that this doesn't break anything.
> This looks good to me. I can't think of any other syntax scenarios that
> it needs to address.
Pushed, thanks for checking!
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, feikesteenbergen@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15555: Syntax errors when using the COMMENT command in plpgsql and a "comment" variable
In-Reply-To: <7799.1546622304@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox