pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
To: Michael Paquier <michael@paquier.xyz>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Luis Carril <luis.carril@swarm64.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Cc: PG Bug reporting form <noreply@postgresql.org>
Cc: Michael Paquier <michael.paquier@gmail.com>
Subject: Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction
Date: Fri, 21 Dec 2018 12:49:25 +0900
Message-ID: <5C1C62C5.8040409@lab.ntt.co.jp> (raw)
In-Reply-To: <20181220003140.GE27104@paquier.xyz>
References: <LEJPR01MB00109D0BECB8A961074A7CAFE7BC0@LEJPR01MB0010.DEUPRD01.PROD.OUTLOOK.DE>
	<30718b48-8020-329a-c6f0-74e1222e5283@lab.ntt.co.jp>
	<5C18ECBB.2000507@lab.ntt.co.jp>
	<LEJPR01MB001074FD67CB65B539122E4DE7BD0@LEJPR01MB0010.DEUPRD01.PROD.OUTLOOK.DE>
	<3539e73a-313a-5406-27c7-850affb47921@lab.ntt.co.jp>
	<20181219023814.GA6577@paquier.xyz>
	<6daa6d4a-d4a9-bd2c-0b84-c4e31d2b9844@lab.ntt.co.jp>
	<5C19F7FF.9060904@lab.ntt.co.jp>
	<20181219083422.GA680@paquier.xyz>
	<5C1A0B6C.1040502@lab.ntt.co.jp>
	<20181220003140.GE27104@paquier.xyz>

(2018/12/20 9:31), Michael Paquier wrote:
> On Wed, Dec 19, 2018 at 06:12:12PM +0900, Etsuro Fujita wrote:
>> I think so too.  I think it might be better to add regression tests for the
>> view case as well, though.
>
> Agreed.

Cool.

>>> Would you like to
>>> update the patch yourself?
>>
>> I'd be happy if you worked on that.
>
> Attached is the patch with two new test cases blowing with wal_level =
> minimal.  On HEAD, I suggest that we use RELKIND_CAN_HAVE_STORAGE to not
> fall again in this trap in the future.  For back-branches, let's just
> add the appropriate relkind checks as suggested upthread.

To make maintenance easy, I think it might be better to add the 
appropriate relkind checks on HEAD as well.  Other than that, the patch 
looks good to me.

> Please note
> that the attached patch is for HEAD, and I'll adjust for other branches.
> The view part needs to go down to v10, and the part for foreign tables
> down to v11.

Thanks for the updated patch!

Best regards,
Etsuro Fujita





view thread (37+ messages)  latest in thread

Message-ID: <5C1C62C5.8040409@lab.ntt.co.jp>
Permalink:  ../5C1C62C5.8040409@lab.ntt.co.jp/
Also on:    postgresql.org/message-id/5C1C62C5.8040409@lab.ntt.co.jp

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: fujita.etsuro@lab.ntt.co.jp, michael@paquier.xyz, Langote_Amit_f8@lab.ntt.co.jp, luis.carril@swarm64.com, pgsql-bugs@lists.postgresql.org, noreply@postgresql.org, michael.paquier@gmail.com
  Subject: Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction
  In-Reply-To: <5C1C62C5.8040409@lab.ntt.co.jp>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox