From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Stepan Yankevych <stepya@ukr.net>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-bugs@lists.postgresql.org
Cc: etsuro.fujita@gmail.com
Subject: Re: BUG #15724: Can't create foreign table as partition
Date: Fri, 05 Apr 2019 21:07:47 +0900
Message-ID: <5CA74513.3040408@lab.ntt.co.jp> (raw)
In-Reply-To: <6e24fca7-07d1-4f6c-80ec-e817b58859bd@lab.ntt.co.jp>
References: <21389.1553868091@sss.pgh.pa.us>
<20190329141050.GA22336@alvherre.pgsql>
<1553869152.858391073.5f8m3n0x@frv53.fwdcdn.com>
<5CA1A94E.1070002@lab.ntt.co.jp>
<6e24fca7-07d1-4f6c-80ec-e817b58859bd@lab.ntt.co.jp>
(2019/04/01 15:45), Amit Langote wrote:
> On 2019/04/01 15:01, Etsuro Fujita wrote:
>> +1 for adding such notes, but I'm not sure if it's a good idea to put it
>> there because I think that would make the introductory documentation a bit
>> verbose. How about adding it to the reference pages of CREATE FOREIGN
>> TABLE and ALTER TABLE like the attached?
>
> Thanks for creating the patch. Looks good to me.
Pushed after fixing a copy-pasto: s/sql-createtable/sql-createforeigntable/
Thanks for reviewing, Amit-san!
Best regards,
Etsuro Fujita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: fujita.etsuro@lab.ntt.co.jp, Langote_Amit_f8@lab.ntt.co.jp, stepya@ukr.net, alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, pgsql-bugs@lists.postgresql.org, etsuro.fujita@gmail.com
Subject: Re: BUG #15724: Can't create foreign table as partition
In-Reply-To: <5CA74513.3040408@lab.ntt.co.jp>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox