From: Andrei Lepikhov <lepihov@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Richard Guo <guofenglinux@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18576: Using EXPLAIN (VERBOSE) in information_schema.element_types returns ERROR: failed to find plan for
Date: Mon, 19 Aug 2024 19:11:00 +0200
Message-ID: <5e129a8e-5b8d-4a61-9776-59be99a2c14f@gmail.com> (raw)
In-Reply-To: <1385302.1724085401@sss.pgh.pa.us>
References: <18576-9feac34e132fea9e@postgresql.org>
<CAMbWs49gOeyotM7riJ-q_NgLgfA6-3z7DffnR71kSyaHTkh2ig@mail.gmail.com>
<2336091.1723137115@sss.pgh.pa.us>
<2493069.1723149304@sss.pgh.pa.us>
<CAMbWs4_Au2i+p2MbZ8nNB_QQXrFy65CXNeJL11j2WJbNW18fHQ@mail.gmail.com>
<2548861.1723174234@sss.pgh.pa.us>
<2799439.1723217127@sss.pgh.pa.us>
<332f0e30-f90a-4e47-b668-b53f649c244f@gmail.com>
<1385302.1724085401@sss.pgh.pa.us>
On 19/8/2024 18:36, Tom Lane wrote:
> Andrei Lepikhov <lepihov@gmail.com> writes:
>> Thanks for pushing this!
>
>> But could you change this code a little bit?
>> I reported this issue a year ago. At that time, it was triggered by the
>> CustomScan node [1]. I haven't found the solution there [2]. Your code
>> looks like a good tradeoff, and if you slightly change the code (like in
>> the attachment), it allows CustomScan to survive such cases.
>
> This seems like it's making assumptions it shouldn't about what
> CustomScan does. If there's an argument for doing this, it should
> be added to the adjacent comments.
Hm, I got into this problem many times using CustomScan node. Do you
have some objections to not allow CustomScan node have a RECORD Var in
the target list? For example, once I got this bug designing CustomScan
which gathered lightweight statistics on-the-fly under a Sort and
GROUP-BY nodes. I didn't change any tuple and had the same target list
as the child node. Why we should analyse target list and don't use
CustomScan if it contains Var of specific type?
>
> (Also, what's with the random change in contrib/Makefile?)
Oops, it's a waste code, pardon.
--
regards, Andrei Lepikhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: lepihov@gmail.com, tgl@sss.pgh.pa.us, guofenglinux@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18576: Using EXPLAIN (VERBOSE) in information_schema.element_types returns ERROR: failed to find plan for
In-Reply-To: <5e129a8e-5b8d-4a61-9776-59be99a2c14f@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox