From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: asphator@gmail.com
To: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18663: synchronous_standby_names vs synchronous_commit vs pg_stat_replication
Date: Thu, 9 Jan 2025 09:35:39 +0900
Message-ID: <614200e4-9434-4aad-b44d-078bc6d5e65a@oss.nttdata.com> (raw)
In-Reply-To: <a8794ab2-7fba-4541-98fa-528b1e03852c@oss.nttdata.com>
References: <18663-b02f75cb919f1b60@postgresql.org>
<a8794ab2-7fba-4541-98fa-528b1e03852c@oss.nttdata.com>
On 2024/10/21 18:43, Fujii Masao wrote:
>
>
> On 2024/10/18 23:48, PG Bug reporting form wrote:
>> The following bug has been logged on the website:
>>
>> Bug reference: 18663
>> Logged by: Asphator
>> Email address: asphator@gmail.com
>> PostgreSQL version: 15.7
>> Operating system: RHEL7+
>> Description:
>>
>> Hello
>>
>> I would like to raise 2 issues:
>> - documentation issue
>> - pg_stat_replication view issue in a very specific use case
>>
>> 1. Documentation
>> Regarding parameter synchronous_standby_names, I did not manage to find
>> anything in documentation preventing from setting value 0. The only thing
>> I've found is a comment in a commit of 2016. Would be nice to mention in
>> documentation that value must be a "positive" integer.
>
> Agreed. I've attached the patch.
I made a slight wording adjustment.
Unless there are objections, I'll commit the attached patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Attachments:v2-0001-doc-Clarify-synchronous_standby_names-parameter.patch (text/plain, 1.3K) download
From 4bb69b55e060dc4124ba55dcd7dca164cc76c09d Mon Sep 17 00:00:00 2001
From: Fujii Masao <fujii@postgresql.org>
Date: Thu, 9 Jan 2025 09:26:36 +0900
Subject: [PATCH v2] doc: Clarify synchronous_standby_names parameter.
The synchronous_standby_names GUC allows specifying num_sync,
the number of synchronous standbys transactions must wait for
replies from. This value must be an integer greater than zero.
This commit updates the documentation to clarify this requirement.
Reported-by: Asphator <asphator@gmail.com>
Discussion: https://postgr.es/m/18663-b02f75cb919f1b60@postgresql.org
---
doc/src/sgml/config.sgml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgmlindex 8683f0bdf5..f1ab614575 100644--- a/doc/src/sgml/config.sgml+++ b/doc/src/sgml/config.sgml@@ -4715,6 +4715,8 @@ ANY <replaceable class="parameter">num_sync</replaceable> ( <replaceable class="
wait for replies from,
and <replaceable class="parameter">standby_name</replaceable>
is the name of a standby server.
+ <replaceable class="parameter">num_sync</replaceable>+ must be an integer value greater than zero.
<literal>FIRST</literal> and <literal>ANY</literal> specify the method to choose
synchronous standbys from the listed servers.
</para>
--
2.47.0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: masao.fujii@oss.nttdata.com, asphator@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18663: synchronous_standby_names vs synchronous_commit vs pg_stat_replication
In-Reply-To: <614200e4-9434-4aad-b44d-078bc6d5e65a@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox